[JIRA] (JOIDCRP-19) Add audit context actions and audit extractors where necessary

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JOIDCRP-19 ( https://shibboleth.atlassian.net/browse/JOIDCRP-19?atlOrigin=eyJpIjoiYzEwODBlNmNjOTU2NDQ3MGIwNDU5ZDUzMmY0ODk4NDkiLCJwIjoiaiJ9 )

Re: Add audit context actions and audit extractors where necessary ( https://shibboleth.atlassian.net/browse/JOIDCRP-19?atlOrigin=eyJpIjoiYzEwODBlNmNjOTU2NDQ3MGIwNDU5ZDUzMmY0ODk4NDkiLCJwIjoiaiJ9 )

This is mainly done. I just need to clean up some of the places writeaudit could be called unnecessarily.

Quick question to Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) , the saml-authn proxy calls write-audit twice, once on-exit from the end of the flow - which I get. The other is just before the external SAML call. Does the first call exist such that something is audited in case the external call does not return?

If so, I think it makes sense to do the same thing with the RP proxy.

( https://shibboleth.atlassian.net/browse/JOIDCRP-19#add-comment?atlOrigin=eyJpIjoiYzEwODBlNmNjOTU2NDQ3MGIwNDU5ZDUzMmY0ODk4NDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDCRP-19#add-comment?atlOrigin=eyJpIjoiYzEwODBlNmNjOTU2NDQ3MGIwNDU5ZDUzMmY0ODk4NDkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:3ac329d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/fcd73785/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9f0a623d-8d14-49cb-be06-5e82b62eb91c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/fcd73785/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ffc3128b-7922-4eb7-8fc5-956f99646040
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/fcd73785/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8f98e963-490e-42d9-a44e-d092f52d8f3f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/fcd73785/attachment-0005.png>