[java-idp-plugin-oidc-rp] branch main updated: Fix Javadoc

Phil Smart philip.smart at jisc.ac.uk
Fri Oct 28 13:52:33 UTC 2022


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=025d6a4eed75e9c24c24bb9e85f3631631048a18

The following commit(s) were added to refs/heads/main by this push:
     new 025d6a4  Fix Javadoc
025d6a4 is described below

commit 025d6a4eed75e9c24c24bb9e85f3631631048a18
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Oct 28 14:52:27 2022 +0100

    Fix Javadoc
---
 .../idp/plugin/authn/oidc/rp/impl/AuthorizationControllerTest.java  | 6 +++++-
 .../shibboleth/idp/plugin/authn/oidc/rp/impl/TestTokenHelper.java   | 2 +-
 .../idp/plugin/authn/oidc/rp/impl/ValidateResponseStateTest.java    | 2 +-
 .../authn/oidc/rp/messaging/impl/AddRedirectURIHandlerTest.java     | 4 +---
 .../plugin/authn/oidc/rp/messaging/impl/AddScopesHandlerTest.java   | 2 +-
 .../oidc/rp/messaging/impl/BuildPlainRequestObjectJWTTest.java      | 2 +-
 6 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationControllerTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationControllerTest.java
index fb47b43..139c974 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationControllerTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationControllerTest.java
@@ -219,7 +219,11 @@ public class AuthorizationControllerTest extends AbstractTestNGSpringContextTest
         assertTrue(result.getResponse().getRedirectedUrl().contains("state"));
     }
     
-    /** Add a simple RequestObject JWT to the authentication request.*/
+    /** 
+     * Add a simple RequestObject JWT to the authentication request.
+     * 
+     * @param request the authentication request
+     */
     private void addRequestObject(@Nonnull final OIDCAuthenticationRequest request) {
         
         final ClaimsSet requestObjectClaims = new ClaimsSet();
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/TestTokenHelper.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/TestTokenHelper.java
index 5607d1f..96b184d 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/TestTokenHelper.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/TestTokenHelper.java
@@ -216,7 +216,7 @@ public final class TestTokenHelper {
      * @return the signed JWT alongside the pair of signature and encryption keys
      * @throws Exception 
      * 
-     * @throws JOSEException on error
+     * @throws Exception on error
      */
     public static Pair<Pair<ECKey, RSAKey>, EncryptedJWT> createAsymetricSignedAndAsymetricEncryptedUserInfoJWTResponse(
             final String issuer, final List<String> audience, final String clientId) throws Exception {
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseStateTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseStateTest.java
index 6cf31ad..1ddf18d 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseStateTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseStateTest.java
@@ -41,7 +41,7 @@ import net.shibboleth.idp.relyingparty.RelyingPartyConfiguration;
 import net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration;
 import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
 
-/** Tests for {@link AddRedirectURI}.*/
+/** Tests for {@link ValidateResponseState}.*/
 public class ValidateResponseStateTest extends AbstractOIDCTest {
     
     /** The action to test.*/
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddRedirectURIHandlerTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddRedirectURIHandlerTest.java
index 85ea2ea..beaa51d 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddRedirectURIHandlerTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddRedirectURIHandlerTest.java
@@ -25,14 +25,12 @@ import org.opensaml.messaging.handler.MessageHandlerException;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
-import net.shibboleth.idp.plugin.authn.oidc.rp.context.OAuth2ClientContext;
 import net.shibboleth.idp.plugin.authn.oidc.rp.impl.AbstractOIDCTest;
 import net.shibboleth.idp.profile.context.RelyingPartyContext;
 import net.shibboleth.idp.relyingparty.RelyingPartyConfiguration;
-import net.shibboleth.oidc.authn.context.OAuth2ClientAuthenticationContext;
 import net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration;
 
-/** Tests for {@link AddRedirectURI}.*/
+/** Tests for {@link AddRedirectURIHandler}.*/
 public class AddRedirectURIHandlerTest extends AbstractOIDCTest {
     
     /** The action to test.*/
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddScopesHandlerTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddScopesHandlerTest.java
index 559d489..76d4b53 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddScopesHandlerTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddScopesHandlerTest.java
@@ -30,7 +30,7 @@ import net.shibboleth.idp.profile.context.RelyingPartyContext;
 import net.shibboleth.idp.relyingparty.RelyingPartyConfiguration;
 import net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration;
 
-/** Tests for {@link AddScopes}.*/
+/** Tests for {@link AddScopesHandler}.*/
 public class AddScopesHandlerTest extends AbstractOIDCTest {
     
     /** The action to test.*/
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/BuildPlainRequestObjectJWTTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/BuildPlainRequestObjectJWTTest.java
index b92920d..5a48da9 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/BuildPlainRequestObjectJWTTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/BuildPlainRequestObjectJWTTest.java
@@ -33,7 +33,7 @@ import net.shibboleth.idp.plugin.authn.oidc.rp.context.OutboundMessageHandlerCon
 import net.shibboleth.idp.plugin.authn.oidc.rp.impl.AbstractOIDCTest;
 import net.shibboleth.oidc.profile.core.OIDCAuthenticationRequest;
 
-/** Tests for BuildPlainRequestObjectJWT.*/
+/** Tests for {@link BuildPlainRequestObjectJWT}.*/
 public class BuildPlainRequestObjectJWTTest extends AbstractOIDCTest {
     
     /** The SWF key.*/

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list