[java-oidc-common] branch main updated: Fix accidental commit to resolver

Phil Smart philip.smart at jisc.ac.uk
Fri Oct 28 09:25:17 UTC 2022


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=d73094162a699e9082192ff36607bb67f0e78698

The following commit(s) were added to refs/heads/main by this push:
     new d730941  Fix accidental commit to resolver
d730941 is described below

commit d73094162a699e9082192ff36607bb67f0e78698
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Oct 28 10:25:12 2022 +0100

    Fix accidental commit to resolver
---
 .../credential/impl/ProviderMetadataCredentialResolver.java       | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/credential/impl/ProviderMetadataCredentialResolver.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/credential/impl/ProviderMetadataCredentialResolver.java
index 247a765..9244d4b 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/credential/impl/ProviderMetadataCredentialResolver.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/credential/impl/ProviderMetadataCredentialResolver.java
@@ -17,7 +17,6 @@
 
 package net.shibboleth.oidc.security.credential.impl;
 
-import java.net.URI;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.Collection;
@@ -137,9 +136,9 @@ public class ProviderMetadataCredentialResolver extends BasicJOSEObjectCredentia
             @Nonnull final OIDCProviderMetadata metadata) {
         
         final LinkedHashSet<Credential> credentials = new LinkedHashSet<>(1);
-        try {
+        
         if (metadata.getJWKSetURI() != null) {
-            final JWKSet keySet = remoteJwkSetCache.fetch(new URI("https://smart.local:4443/"),
+            final JWKSet keySet = remoteJwkSetCache.fetch(metadata.getJWKSetURI(),
                     Instant.now().plus(keyFetchInterval));
             
             if (keySet == null) {
@@ -166,9 +165,6 @@ public class ProviderMetadataCredentialResolver extends BasicJOSEObjectCredentia
         } else {
             log.trace("No JWK Set available, no credentials returned");
         }
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
         return credentials;
    
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list