[JIRA] (JSSH-18) Consider adding spring support classed to shib-shared-testing

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JSSH-18?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 ) JSSH-18 ( https://shibboleth.atlassian.net/browse/JSSH-18?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 ) Consider adding spring support classed to shib-shared-testing ( https://shibboleth.atlassian.net/browse/JSSH-18?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 )

Issue Type: Task Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Created: 25/Oct/22 8:37 AM Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

This case is open for discussion. Happy to close it as won’t do

I was looking at a case in which it would have been handy to get a DataConnector from a definition contained in more than one file and it turned out that in order to do this I would have pretty much had to duplicate methods (from taking a String file to Collection<String> files all the way down the calling chain - so I bottled it for V4.

But then I started looking at the code in the round and (as the person who wrote much of this code) I was unsurprised to find a great deal of cut and paste in spring support (for instance across the entire J17 stack I can count 17 declarations

protected <T> T getBean(final Class<T> .....)

in 10 files.

It would (I believe) be great to do a review of all of these methods and pull them into shib-testing Then when we get a need to do something like “load a data connector from more than one file” the change can be made in one place and become available everywhere.

I don’t underestimate the magnitude of this task - each of the 10 different implementations will have diverged after the initial cut and paste and we need to find a common ground which might be hard given the different things than can be changed (property files, converters, post bean processed, post factory processors &c &c).

Before I start thinking about this I wanted to capture the idea and seek feedback

( https://shibboleth.atlassian.net/browse/JSSH-18#add-comment?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-18#add-comment?atlOrigin=eyJpIjoiYWI2OTYzNzRmOWFhNGMwY2I0YjI0YzJjYWY5YzgyNzciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:9aa9d1d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221025/274b1dc8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1a6f574a-b129-4e15-994d-4b7c732dae59
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221025/274b1dc8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-16368477-1d93-48ba-b69b-ecc962043531
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221025/274b1dc8/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-427dba72-634f-464e-91ba-7d9fd3ee8675
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221025/274b1dc8/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8d10fdcb-40f1-4b86-a969-d08fcc053675
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221025/274b1dc8/attachment-0007.png>