[java-metadata-aggregator] 04/04: Remove redundant abstract method; fix a locking issue (Spotbugs)

[Ian Young]

This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch main
in repository java-metadata-aggregator.

View the commit online:
http://git.shibboleth.net/view/?p=java-metadata-aggregator.git;a=commit;h=0df5bebb585a153479b1a7be04803300638cd7f6

commit 0df5bebb585a153479b1a7be04803300638cd7f6
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Mon Oct 24 11:01:31 2022 +0100

    Remove redundant abstract method; fix a locking issue (Spotbugs)
---
 .../metadata/dom/AbstractAttributeValidationStage.java         | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/mda-framework/src/main/java/net/shibboleth/metadata/dom/AbstractAttributeValidationStage.java b/mda-framework/src/main/java/net/shibboleth/metadata/dom/AbstractAttributeValidationStage.java
index d330e75..5969072 100644
--- a/mda-framework/src/main/java/net/shibboleth/metadata/dom/AbstractAttributeValidationStage.java
+++ b/mda-framework/src/main/java/net/shibboleth/metadata/dom/AbstractAttributeValidationStage.java
@@ -142,14 +142,6 @@ public abstract class AbstractAttributeValidationStage<T> extends AbstractElemen
         }
     }
     
-    /**
-     * Convert the visited {@link Attr} to the type to be validated.
-     *
-     * @param attr {@link Attr} being validated
-     * @return converted value
-     */
-    protected abstract @Nonnull T convert(final @Nonnull Attr attr);
-
     /**
      * Returns whether the given attribute is applicable to our traversal.
      *
@@ -159,7 +151,7 @@ public abstract class AbstractAttributeValidationStage<T> extends AbstractElemen
      */
     protected boolean applicable(@Nonnull final Attr attr, @Nonnull final DOMTraversalContext context) {
         final var attrName = new QName(attr.getNamespaceURI(), attr.getLocalName());
-        return attributeNames.contains(attrName);
+        return getAttributeNames().contains(attrName);
     }
 
     @Override

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.