[java-metadata-aggregator] 01/04: Nullability and polish

[Ian Young]

This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch main
in repository java-metadata-aggregator.

View the commit online:
http://git.shibboleth.net/view/?p=java-metadata-aggregator.git;a=commit;h=0836526e1f7ae62e196e8c5c71e45da74e0b07e0

commit 0836526e1f7ae62e196e8c5c71e45da74e0b07e0
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Mon Oct 24 09:01:20 2022 +0100

    Nullability and polish
---
 .../metadata/dom/AbstractDOMValidationStageTest.java       | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/mda-framework/src/test/java/net/shibboleth/metadata/dom/AbstractDOMValidationStageTest.java b/mda-framework/src/test/java/net/shibboleth/metadata/dom/AbstractDOMValidationStageTest.java
index 4d8347a..31c69bf 100644
--- a/mda-framework/src/test/java/net/shibboleth/metadata/dom/AbstractDOMValidationStageTest.java
+++ b/mda-framework/src/test/java/net/shibboleth/metadata/dom/AbstractDOMValidationStageTest.java
@@ -21,6 +21,8 @@ package net.shibboleth.metadata.dom;
 import java.util.ArrayList;
 import java.util.List;
 
+import javax.annotation.Nonnull;
+
 import org.testng.Assert;
 import org.testng.annotations.Test;
 import org.w3c.dom.Element;
@@ -40,17 +42,18 @@ public class AbstractDOMValidationStageTest extends BaseDOMTest {
     private static class StringValidationStage extends AbstractDOMValidationStage<String, DOMTraversalContext> {
 
         @Override
-        protected boolean applicable(Element element, DOMTraversalContext context) {
+        protected boolean applicable(final @Nonnull Element element, final @Nonnull DOMTraversalContext context) {
             return "checkedElement".equals(element.getLocalName());
         }
 
         @Override
-        protected void visit(Element element, DOMTraversalContext context) throws StageProcessingException {
+        protected void visit(final @Nonnull Element element, final @Nonnull DOMTraversalContext context)
+                throws StageProcessingException {
             applyValidators(element.getTextContent(), context);
         }
 
         @Override
-        protected DOMTraversalContext buildContext(Item<Element> item) {
+        protected @Nonnull DOMTraversalContext buildContext(final @Nonnull Item<Element> item) {
             return new SimpleDOMTraversalContext(item);
         }
 
@@ -59,7 +62,7 @@ public class AbstractDOMValidationStageTest extends BaseDOMTest {
     private static class FirstStringValidator extends BaseValidator implements Validator<String> {
 
         @Override
-        public Action validate(String e, Item<?> item, String stageId)
+        public @Nonnull Action validate(final @Nonnull String e, final @Nonnull Item<?> item, final @Nonnull String stageId)
                 throws StageProcessingException {
             addError("element contains " + e, item, stageId);
             return Action.DONE; // once per value checked
@@ -70,7 +73,8 @@ public class AbstractDOMValidationStageTest extends BaseDOMTest {
     private static class UnexecutedStringValidator extends BaseValidator implements Validator<String> {
 
         @Override
-        public Action validate(String e, Item<?> item, String stageId)
+        public @Nonnull Action validate(final @Nonnull String e, final @Nonnull Item<?> item,
+                final @Nonnull String stageId)
                 throws StageProcessingException {
             Assert.fail("should not execute this");
             return Action.CONTINUE;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.