[JIRA] (MDA-231) Add stage to validate selected DOM attributes as strings

Ian Young (Jira) jira at shibboleth.atlassian.net
Sat Oct 22 15:35:02 UTC 2022


Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-231 ( https://shibboleth.atlassian.net/browse/MDA-231?atlOrigin=eyJpIjoiZTFkOWI4NTU3M2U2NDZkZGE5ZjYzNzUwMTA3MDQ3ZmYiLCJwIjoiaiJ9 )

Re: Add stage to validate selected DOM attributes as strings ( https://shibboleth.atlassian.net/browse/MDA-231?atlOrigin=eyJpIjoiZTFkOWI4NTU3M2U2NDZkZGE5ZjYzNzUwMTA3MDQ3ZmYiLCJwIjoiaiJ9 )

I have a working version of this now, plus unit tests with good coverage. I still need documentation, and in particular I want to document this one on the wiki to see what that looks like.

I am not completely happy about the implementation and in particular I think the fact that I ended up with a method which implements something from an ancestor class by throwing an UnsupportedOperationException probably indicates that the class hierarchy could be improved, perhaps by putting in yet another intermediate abstract class. This would all be a lot easier in a language that had mixins or another kind of multiple inheritance, but I think there is still a better approach available even in Java.

( https://shibboleth.atlassian.net/browse/MDA-231#add-comment?atlOrigin=eyJpIjoiZTFkOWI4NTU3M2U2NDZkZGE5ZjYzNzUwMTA3MDQ3ZmYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-231#add-comment?atlOrigin=eyJpIjoiZTFkOWI4NTU3M2U2NDZkZGE5ZjYzNzUwMTA3MDQ3ZmYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:392b984 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221022/810fb118/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6567d60d-57db-44e2-8181-62a26e28e371
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221022/810fb118/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-084aeb70-6998-4c5f-bff1-36148e6fcf39
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221022/810fb118/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-2d20e252-4ff5-4b63-8b33-fdbea22e0f65
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221022/810fb118/attachment-0005.png>


More information about the commits mailing list