[JIRA] (IDP-2024) Clean up passing of Properties too and from Windows Installer VBScripts

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/IDP-2024?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 ) IDP-2024 ( https://shibboleth.atlassian.net/browse/IDP-2024?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 ) Clean up passing of Properties too and from Windows Installer VBScripts ( https://shibboleth.atlassian.net/browse/IDP-2024?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 5.0.0 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Installer Created: 14/Oct/22 11:44 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

The IdP Installer uses a paradigm inherited from the old SP (v1?) installer whereby the parameters to a VbScript are concatenated to each other separated by ;@;

<CustomAction Id="SetWriteConfigFiles" Property="WriteConfigFiles" 
Value="[INSTALLDIR];@;[DNSNAME];@;[INSTALL_JETTY];@;[IDP_SCOPE];@;[DEBUG_INSTALL];@;[CONFIGURE_AD];@;[AD_DOMAIN];@;[AD_USER];@;[AD_PASS];@;[AD_USE_GC]" />

and the vbscript then says

CustomData = Session.Property("CustomActionData")
msiProperties = split(CustomData,";@;")
var InstallDir=msiProperties(0)
var DnsName=msiProperties(1)
......

This neglects the fact that you can read and properties directly from the VbScript (which is used in other scripts) for instance

' c:\program file\foo\bar/idp/ -> c:/program file/foo/bar/idp
newHome = Replace(Session.Property("INSTALLDIR"), "\", "/")
if (Right(newHome, 1) = "/") then
   Session.Property("JAVA_IDP_HOME") = Left(newHome, Len(newHome) -1)
else 
   Session.Property("JAVA_IDP_HOME") = newHome
end if

we should get rid of this cumbersome indirection

( https://shibboleth.atlassian.net/browse/IDP-2024#add-comment?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2024#add-comment?atlOrigin=eyJpIjoiNGRiOTE1M2YxMzNhNGI2ZmFiMTUzMWEyMmJlZjBiMDMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221014/bbfce3db/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e1ed519e-5829-4084-969f-5c9e1b7badc0
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221014/bbfce3db/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-4f0a688b-c01b-47b7-985a-d22933711c9f
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221014/bbfce3db/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ec961092-37b5-4d31-85d0-8142e401fac9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221014/bbfce3db/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-402b7f28-f8a5-40cf-aa17-60ca344abbd7
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221014/bbfce3db/attachment-0007.png>