[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Mon Nov 28 20:14:49 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZDY4MjRlYzhjMmFlNDA0MzljYjBhNTJjYjQ0NGRiNDAiLCJwIjoiaiJ9 )
Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZDY4MjRlYzhjMmFlNDA0MzljYjBhNTJjYjQ0NGRiNDAiLCJwIjoiaiJ9 )
I flagged all calls to getServiceableComponent() and added catch clauses to replace the null handling. That will eventually get flagged as dead code if we adjust the null checking, so more of them might get flushed out.
( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZDY4MjRlYzhjMmFlNDA0MzljYjBhNTJjYjQ0NGRiNDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZDY4MjRlYzhjMmFlNDA0MzljYjBhNTJjYjQ0NGRiNDAiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/d69360e8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-543c0593-9eae-4140-84e5-980649ab5b90
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/d69360e8/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-129502c4-deaf-41a8-a8fb-f1ef2abac7bf
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/d69360e8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e6451903-f876-479a-82c0-47c52987d4a7
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/d69360e8/attachment-0005.png>
More information about the commits
mailing list