[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiMzI3ZDU0NzdlNzBhNGMyNWIyZTgzOTlkYmFlMjFkNWIiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiMzI3ZDU0NzdlNzBhNGMyNWIyZTgzOTlkYmFlMjFkNWIiLCJwIjoiaiJ9 )

Something very odd with ServiceableAccessControlService and ReloadingAccessControlService

* They are the same code and only differ in class name
* They are serviceable*Components* not services (although the word service is overloaded here since the implement AccessControlService
* The first is never referenced (code, documentation, xml)
* The second is created as a one off (& anonymous) in access-control-system.xml and not used?
* If I understood what they did they could be implemented as SpringServiceableComponent (which is a good reason for that name being wrong)

I'll leave this as an open question.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiMzI3ZDU0NzdlNzBhNGMyNWIyZTgzOTlkYmFlMjFkNWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiMzI3ZDU0NzdlNzBhNGMyNWIyZTgzOTlkYmFlMjFkNWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221125/ad7ea13e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1ef0aa57-ce4a-4d7f-a151-bdc8d4850bc3
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221125/ad7ea13e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-eae2a6f1-18ca-4175-988b-cbacc85efe4a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221125/ad7ea13e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a97322b9-bf42-4e68-a244-80189f878b24
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221125/ad7ea13e/attachment-0005.png>