[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Thu Nov 24 17:11:44 UTC 2022


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiOTg0NzY3OGU1Y2Y0NGFiY2I0MWExNjBjYWFlMmZkNzEiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiOTg0NzY3OGU1Y2Y0NGFiY2I0MWExNjBjYWFlMmZkNzEiLCJwIjoiaiJ9 )

This works quite nicely. I’ll work through this by hand but my major problem is one of nomenclature.

We need a name for the class which is the ServiceableComponent which is used. ServiceableComponent is the interface so I am (for now) going for SpringServiceableComponent (which extends AbstractServiceableComponent).

Ultimately AbstractServiceableComponent will disappear I think.

I’ll clean up what I have done and commit it, then I can work through all the others .

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiOTg0NzY3OGU1Y2Y0NGFiY2I0MWExNjBjYWFlMmZkNzEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiOTg0NzY3OGU1Y2Y0NGFiY2I0MWExNjBjYWFlMmZkNzEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221124/2b15004c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-725d348c-4d47-4d39-ae1e-6358b8d1cc37
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221124/2b15004c/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-7c6cdb7b-224c-4d70-9393-32a7c3e10735
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221124/2b15004c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1f28d281-e7c0-4ff2-b007-9b28442497d9
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221124/2b15004c/attachment-0005.png>


More information about the commits mailing list