[JIRA] (JOIDC-137) KeySet audit logging missing informative response binding value

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *created* an issue

IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JOIDC-137?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 ) JOIDC-137 ( https://shibboleth.atlassian.net/browse/JOIDC-137?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 ) KeySet audit logging missing informative response binding value ( https://shibboleth.atlassian.net/browse/JOIDC-137?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1 Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Components: Logging and Metrics Created: 23/Nov/22 7:09 AM Priority: Trivial Reporter: Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 )

The OutboundMessageClassLookupFunction has a bug preventing it from extracting the OUTBOUND_MESSAGE_CLASS to add to the KeySet audit log (as the SAML RESPONSE_BINDING field). The bug is on line 46 (it checks the inbound context, not the outbound).

Even if that works, the audit log only contains JSONSuccessResponse as the response binding field value. This is not very descriptive of a KeySet response. Maybe the response class could be more specific.

( https://shibboleth.atlassian.net/browse/JOIDC-137#add-comment?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-137#add-comment?atlOrigin=eyJpIjoiZDgwZWZhODk2MmI0NDQzZmE0Y2YyZmJhMjRlMjA3NmQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221123/a91f4618/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-37d040ee-aafe-45ba-af0d-811f1168b692
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221123/a91f4618/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-a5ac520d-a1f8-4612-97b5-8717d0ef390c
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221123/a91f4618/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4051e2d1-692c-472b-8781-7eaa57a3d934
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221123/a91f4618/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7f481dd7-123b-45cd-8b80-780327a5f95c
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221123/a91f4618/attachment-0007.png>