[JIRA] (IDP-2035) LDAP connection pools are not freeing connections when shut down

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2035 ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiMTQ4NjVkMjc1NTUyNDFlNTlkYzVkYWYxNmEyZDVkMWIiLCJwIjoiaiJ9 )

Re: LDAP connection pools are not freeing connections when shut down ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiMTQ4NjVkMjc1NTUyNDFlNTlkYzVkYWYxNmEyZDVkMWIiLCJwIjoiaiJ9 )

I can see both sides of the argument, but I wonder if it’s a little odd to have to templatize the abstract connector base class with the actual type of the connector. Seems kind of weird.

Generics being such a mess, I wonder if it suffices to just make the Vallidator interface take DataConnector and let them cast down to see whether they should work. It seems ok to me to have an LDAP connection validator throw if it’s handed an RDBMS connector, etc. It’s not going to happen anyway.

( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiMTQ4NjVkMjc1NTUyNDFlNTlkYzVkYWYxNmEyZDVkMWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiMTQ4NjVkMjc1NTUyNDFlNTlkYzVkYWYxNmEyZDVkMWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221118/c3b165d4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f390965f-ef86-4691-a379-4255e52cdc50
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221118/c3b165d4/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-467425c7-6f1c-4626-b614-9015577f905d
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221118/c3b165d4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-24d42c8a-df5f-47d7-93af-d4316516ab05
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221118/c3b165d4/attachment-0005.png>