[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZjk3Y2RkYWVlNzUwNDZhNGJiZTkyOTAyNTZjYzIwNjEiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZjk3Y2RkYWVlNzUwNDZhNGJiZTkyOTAyNTZjYzIwNjEiLCJwIjoiaiJ9 )

Plausibly what’s missing here is a second layer of classes. I think it’s not AttributeResolverImpl/FilterImpl that should be AutoCloseable (and implementing ServiceableComponent) but a delegating wrapper returned by the ReloadableService that wraps those classes.

In your example, if the stream was stateless and took a context object, it’s the context in fact I would expect to be AutoCloseable. This is roughly the same thing. The wrapper class is the context-like thing that represents the active use of the underlying component.

That also fixes the tests and Spring because the wrapper would never be created by Spring or created in any of the low level tests of the impl classes since they just need to directly create and invoke the impl object. They know they’re not using the component in a shared way.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZjk3Y2RkYWVlNzUwNDZhNGJiZTkyOTAyNTZjYzIwNjEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZjk3Y2RkYWVlNzUwNDZhNGJiZTkyOTAyNTZjYzIwNjEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221117/c4665fea/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4de6f1b5-205a-46a8-a2df-88cb44e7e3f7
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221117/c4665fea/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fead75aa-9e28-4808-99c0-05c4f24fe360
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221117/c4665fea/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5683b70f-c322-4940-83e3-32000c728d69
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221117/c4665fea/attachment-0005.png>