[JIRA] (JOIDC-135) Enable metadata-lookup flow inheritance by other plugins

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *created* an issue

IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JOIDC-135?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 ) JOIDC-135 ( https://shibboleth.atlassian.net/browse/JOIDC-135?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 ) Enable metadata-lookup flow inheritance by other plugins ( https://shibboleth.atlassian.net/browse/JOIDC-135?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Components: Foundation Created: 16/Nov/22 12:11 PM Fix Versions: 3.3.0 Priority: Trivial Reporter: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd )

Other plugins don’t seem to be able to use the metadata-lookup flow as their parent flow in the same way as the OP plugin.

Example stack trace with Jetty:

ERROR [org.springframework.beans.factory.BeanDefinitionStoreException:91] - 
org.springframework.beans.factory.BeanDefinitionStoreException: IOException parsing XML document from URL [jar:file:/tmp/jetty-0.0.0.0-8080-idp.war-_idp-any-15973031117973182336.dir/webinf/WEB-INF/lib/custom-check-1.0-SNAPSHOT.jar!/META-INF/net/shibboleth/idp/oidc/metadata-lookup/metadata-lookup-beans.xml]; nested exception is java.io.FileNotFoundException: JAR entry META-INF/net/shibboleth/idp/oidc/metadata-lookup/metadata-lookup-beans.xml not found in /tmp/jetty-0.0.0.0-8080-idp.war-_idp-any-15973031117973182336.dir/webinf/WEB-INF/lib/custom-check-1.0-SNAPSHOT.jar
	at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:342)
Caused by: java.io.FileNotFoundException: JAR entry META-INF/net/shibboleth/idp/oidc/metadata-lookup/metadata-lookup-beans.xml not found in /tmp/jetty-0.0.0.0-8080-idp.war-_idp-any-15973031117973182336.dir/webinf/WEB-INF/lib/custom-check-1.0-SNAPSHOT.jar
	at java.base/sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:147)

The error seems to be caused by the fact that the metadata-lookup-flow.xml imports its beans in the following way:

<bean-import resource="../../oidc/metadata-lookup/metadata-lookup-beans.xml" />

The following change seems to fix the problem:

<bean-import resource="classpath:/META-INF/net/shibboleth/idp/flows/oidc/metadata-lookup/metadata-lookup-beans.xml" />

( https://shibboleth.atlassian.net/browse/JOIDC-135#add-comment?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-135#add-comment?atlOrigin=eyJpIjoiYjk0OGRkYzQwYmUxNGZiM2I2OGE1NDA5Njk1ZmQ5ZDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/c5397df8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-51c94a16-0fa1-49d9-bb7c-1015238e0787
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/c5397df8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c4dcc1e6-b6d5-4d76-a1ee-c2b11c5d78cf
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/c5397df8/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-9c06b1c5-5f5b-49d8-9722-ddcb3474af56
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/c5397df8/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-0cdcfba4-1ef2-4e40-a27f-3fe8b9dd9cd9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/c5397df8/attachment-0007.png>