[JIRA] (JDUO-60) idp.authn.DuoOIDC.addDefaultPrincipals property should be supported

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JDUO-60 ( https://shibboleth.atlassian.net/browse/JDUO-60?atlOrigin=eyJpIjoiYTY2YTJlMDk0NGQ4NDMzYjk3OWRiZjQ1MTA3NWY1OTkiLCJwIjoiaiJ9 )

Re: idp.authn.DuoOIDC.addDefaultPrincipals property should be supported ( https://shibboleth.atlassian.net/browse/JDUO-60?atlOrigin=eyJpIjoiYTY2YTJlMDk0NGQ4NDMzYjk3OWRiZjQ1MTA3NWY1OTkiLCJwIjoiaiJ9 )

I’ve tested this and it works. That is:

* if the ContextToPrincipalMappingStrategy is null but idp.authn.DuoOIDC.addDefaultPrincipals is false, the defaults are *not* added — previously they would have been. This represent the desired change.
* If the ContextToPrincipalMappingStrategy is null and idp.authn.DuoOIDC.addDefaultPrincipals is true, the defaults are added — the same as before. This will now be the default, so the behaviour will be the same as before.
* If the ContextToPrincipalMappingStrategy is *not* null and idp.authn.DuoOIDC.addDefaultPrincipals is false, the defaults are not added — the same as before.
* If the ContextToPrincipalMappingStrategy is *not* null and idp.authn.DuoOIDC.addDefaultPrincipals is true, the defaults are not added — the same as before.

( https://shibboleth.atlassian.net/browse/JDUO-60#add-comment?atlOrigin=eyJpIjoiYTY2YTJlMDk0NGQ4NDMzYjk3OWRiZjQ1MTA3NWY1OTkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JDUO-60#add-comment?atlOrigin=eyJpIjoiYTY2YTJlMDk0NGQ4NDMzYjk3OWRiZjQ1MTA3NWY1OTkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d407eaec/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4e7d4be8-7a01-4ac8-894c-80cc7843f0ce
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d407eaec/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-42655d04-0ba1-4650-8072-591beac219c7
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d407eaec/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-df284295-e68e-4cb8-b506-e7307d2dc15c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d407eaec/attachment-0005.png>