[JIRA] (JSATTR-8) LDAP ConnectionFactoryValidator mis-uses Initializable interface

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Shibboleth Attribute Library - Java ( https://shibboleth.atlassian.net/browse/JSATTR?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JSATTR-8?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 ) JSATTR-8 ( https://shibboleth.atlassian.net/browse/JSATTR-8?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 ) LDAP ConnectionFactoryValidator mis-uses Initializable interface ( https://shibboleth.atlassian.net/browse/JSATTR-8?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Attribute Resolver Created: 15/Nov/22 7:08 PM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

There are some glitches in the way the ConnectionFactoryValidator implements the component interface because the LDAP connector actually modifies the validator during its own initiialization, so there’s a cycle you can’t break. The only reason it’s not breaking is that the code apparently isn’t actually invoking initialize most of the time and the “do” method doesn’t check that either.

It appears to me we probably need this to avoid the post-init mutation by exposing the fail-fast semantic as a parameter to the validate method itself.

( https://shibboleth.atlassian.net/browse/JSATTR-8#add-comment?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSATTR-8#add-comment?atlOrigin=eyJpIjoiMjliYTUwMWYwZmRmNGNmZmEyNTA1NGFhODAyZjJiZDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:28a3636 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/f9e35ec1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1bd75efc-175d-4f7e-b391-78eeb8b09fac
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/f9e35ec1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-6b0ea0c7-74b1-4ba2-9e28-26cfbbbd9f9d
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/f9e35ec1/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6a4c4718-35d7-42a4-beb6-620cbbe0e681
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/f9e35ec1/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ff20c640-a999-4d1a-8747-aae7661910a5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/f9e35ec1/attachment-0007.png>