[java-identity-provider] branch maint-4 updated: IDP-2040 - LDAP connection validator has NPE when connection fails

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-4
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=2fc699233b121d871e0f39d978cb0782163b6878

The following commit(s) were added to refs/heads/maint-4 by this push:
     new 2fc699233 IDP-2040 - LDAP connection validator has NPE when connection fails
2fc699233 is described below

commit 2fc699233b121d871e0f39d978cb0782163b6878
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Nov 15 19:02:55 2022 -0500

    IDP-2040 - LDAP connection validator has NPE when connection fails
    
    https://shibboleth.atlassian.net/browse/IDP-2040
---
 .../attribute/resolver/dc/ldap/impl/ConnectionFactoryValidator.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/ConnectionFactoryValidator.java b/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/ConnectionFactoryValidator.java
index f0123d613..9ad25e4d5 100644
--- a/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/ConnectionFactoryValidator.java
+++ b/idp-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/ConnectionFactoryValidator.java
@@ -102,8 +102,9 @@ public class ConnectionFactoryValidator extends AbstractInitializableComponent i
                 if (isThrowValidateError()) {
                     throw new LdapException("Unable to retrieve connection from connection factory");
                 }
+            } else {
+                connection.open();
             }
-            connection.open();
         } catch (final LdapException e) {
             log.error("Connection factory validation failed", e);
             if (isThrowValidateError()) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.