[JIRA] (JSMD-2) Nested X509CredentialNameEvaluatorFactoryBean illegally returns null

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Shibboleth Metadata Library - Java ( https://shibboleth.atlassian.net/browse/JSMD?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JSMD-2?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 ) JSMD-2 ( https://shibboleth.atlassian.net/browse/JSMD-2?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 ) Nested X509CredentialNameEvaluatorFactoryBean illegally returns null ( https://shibboleth.atlassian.net/browse/JSMD-2?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Created: 14/Nov/22 10:54 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

There’s a nested class used in the PKIX trust engine parsing that illegally returns null from a createInstance call on a factory bean.

It’s doing this if the trustedNameCheckEnabled flag is off, which isn’t known until runtime, and if we throw a BeanCreationException, it will break the parser.

Based on the fact that the trust engines handle a null name evaluator by treating the result of the check as “true”, the fix would seem to be to define and return a dummy evaluator so that the factory bean can always return something.

( https://shibboleth.atlassian.net/browse/JSMD-2#add-comment?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSMD-2#add-comment?atlOrigin=eyJpIjoiMmQzZDg5YzI0YTEyNGJlMmJkNDE3MWJhMWVmN2I2NzkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/d3c7716d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-992223e4-3581-4f55-95e8-5ba1e2d4c359
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/d3c7716d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-bd3c99bc-475b-49bd-8776-a2ac8eabbf07
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/d3c7716d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ca093670-8274-45f2-ba34-d749568cd8bd
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/d3c7716d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4f076f6b-9353-4310-8989-65ad0fca3417
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/d3c7716d/attachment-0007.png>