[JIRA] (JSSH-19) Update SameSite filter to use the new Servlet 6.0 API for cookie attributes

Philip Smart (Jira) jira at shibboleth.atlassian.net
Mon Nov 14 14:43:03 UTC 2022


Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JSSH-19?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 ) JSSH-19 ( https://shibboleth.atlassian.net/browse/JSSH-19?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 ) Update SameSite filter to use the new Servlet 6.0 API for cookie attributes ( https://shibboleth.atlassian.net/browse/JSSH-19?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Unassigned Components: Networking Created: 14/Nov/22 9:43 AM Priority: Trivial Reporter: Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 )

Jakarta Servlet 6.0 supports generic cookie attributes. The SameSite filter uses string formatting to append the SameSite attribute. This could be changed to use the new APIs.

This would then require the container to support servlet spec 6.0 and hence will not be implemented until the IdP requires it.

( https://shibboleth.atlassian.net/browse/JSSH-19#add-comment?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-19#add-comment?atlOrigin=eyJpIjoiYWE1MTY0NTFiOTE5NGM1Mjk3NjM3YWRkZDk0NGE2NmEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/0f28385d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5869176d-ca97-4864-b07d-90fca43c5aca
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/0f28385d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1a675857-9e49-4749-945a-f5b11ce03a6f
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/0f28385d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-230a7f8d-8a47-4814-98a5-13d318810587
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/0f28385d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4a51b0fa-971b-4a09-9dd9-025509dd9e8f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221114/0f28385d/attachment-0007.png>


More information about the commits mailing list