[JIRA] (IDP-2035) LDAP connection pools are not freeing connections when shut down

[Daniel Fisher (Jira)]

Daniel Fisher ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3A5040b2f7-37ad-4449-b621-76b5c7e66a9d ) *commented* on IDP-2035 ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiY2Q5NTYyOWY1OTIyNGQ4MThhZDkxMDA5MjgwNTNiYWUiLCJwIjoiaiJ9 )

Re: LDAP connection pools are not freeing connections when shut down ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiY2Q5NTYyOWY1OTIyNGQ4MThhZDkxMDA5MjgwNTNiYWUiLCJwIjoiaiJ9 )

At least one of the problems here is that the LDAP and RDBMS connector parsers are orphaning an instance of their respective connection pools. This is due to the way the BeanDefinition is used in the wiring. A new instance is created separate from the instance used by the data connector.

What I want to do is change (fix) the validator interface so the implementations don’t need a reference to the thing they are validating.

public interface Validator<T extends DataConnector> {
   void validate(T dataConnector) throws ValidationException;

This is a marked improvement for v5 as it cleans up the usage and simplifies the spring lifecycle, but is obviously a breaking API change for v4. A different solution would be needed for v4. I’m still considering those alternatives, but won’t fully circle around until I have fix in place for v5.

( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiY2Q5NTYyOWY1OTIyNGQ4MThhZDkxMDA5MjgwNTNiYWUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiY2Q5NTYyOWY1OTIyNGQ4MThhZDkxMDA5MjgwNTNiYWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221112/163cd8dd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9b768449-f613-4e83-9031-4bcf1a25798f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221112/163cd8dd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2c2d5e23-1096-427c-86ae-b29f0b501e0a
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221112/163cd8dd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ef103bcb-7476-470b-b32e-eb468ed2f4bb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221112/163cd8dd/attachment-0005.png>