[JIRA] (JSPT-119) Deprecate servlet request/response proxies

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Java Support ( https://shibboleth.atlassian.net/browse/JSPT?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JSPT-119?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 ) JSPT-119 ( https://shibboleth.atlassian.net/browse/JSPT-119?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 ) Deprecate servlet request/response proxies ( https://shibboleth.atlassian.net/browse/JSPT-119?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 )

Issue Type: Task Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: net Created: 10/Nov/22 8:52 AM Fix Versions: 8.4.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The servlet APIs are evolving in breaking fashion right now, and Spring has moved up to 6.0 from 5.0, which are impossible to support simultaneously if you’re actually implementing the request/response interfaces unless separate classes are used.

We already changed over all of our code interfaces to use Supplier<> mediated access, which doesn’t require proxying the interfaces.

I propose we deprecate the old proxies in the next minor update and add warnings on all the methods. Then we can remove them from the V5 platform entirely and avoid the problems the servlet spec changes would cause since we won’t be fully implementing the interfaces anymore.

Deployers will feel some pain anywhere the old shibboleth.HttpServletRequest/Response beans are injected, mainly into scripts. The warning will direct them to switch the bean over to the Supplier versions Rod added already, and just change custom to custom.get().

If we actually have typed setters somewhere we could even build a Spring converter to automatically do the dereference, but the majority of cases will be scripts without typed injection points so it’s likely not worth it.

( https://shibboleth.atlassian.net/browse/JSPT-119#add-comment?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-119#add-comment?atlOrigin=eyJpIjoiZWRhZDZkMzAwYzRjNDBjNjgwMmQ4MDU5MzhiZjQyNTAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221110/3675d9b2/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-241ed489-b1e8-4eb8-b42c-4caa3b216aa9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221110/3675d9b2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-0baba63c-46ca-4c51-860f-83cf6ce06bc5
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221110/3675d9b2/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-9c7ef7d4-0d37-460c-a977-fde51023b998
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221110/3675d9b2/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e6d1b2f2-8c38-4b2d-8f30-9c5bb7c6c0a9
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221110/3675d9b2/attachment-0007.png>