[java-shib-attribute] branch main updated: IDP-2035 - LDAP connection pools not freeing connections when shut down

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=8efaf024fc69c272456c04cb6461eeae9e121523

The following commit(s) were added to refs/heads/main by this push:
     new 8efaf024f IDP-2035 - LDAP connection pools not freeing connections when shut down
8efaf024f is described below

commit 8efaf024fc69c272456c04cb6461eeae9e121523
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Nov 8 08:24:32 2022 -0500

    IDP-2035 - LDAP connection pools not freeing connections when shut down
    
    https://shibboleth.atlassian.net/browse/IDP-2035
    
    Added equivalent? patch for Ldaptive 2.
---
 .../idp/attribute/resolver/dc/ldap/impl/LDAPDataConnector.java    | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/shib-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/LDAPDataConnector.java b/shib-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/LDAPDataConnector.java
index 94c2dfb3b..9853bd45a 100644
--- a/shib-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/LDAPDataConnector.java
+++ b/shib-attribute-resolver-impl/src/main/java/net/shibboleth/idp/attribute/resolver/dc/ldap/impl/LDAPDataConnector.java
@@ -154,6 +154,14 @@ public class LDAPDataConnector extends AbstractSearchDataConnector<ExecutableSea
         }
         policeForJVMTrust();
     }
+    
+    /** {@inheritDoc} */
+    @Override protected void doDestroy() {
+        if (connectionFactory != null) {
+            log.info("{} Closing LDAP connection factory", getLogPrefix());
+            connectionFactory.close();
+        }
+    }
 
 // CheckStyle: CyclomaticComplexity OFF
     /** Police TLS for JVM trust.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.