[java-idp-plugin-duo] branch main updated: Make failure logging more consistent.

Scott Cantor cantor.2 at osu.edu
Thu Nov 3 21:06:21 UTC 2022


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=70c829943a134519d0065483455c6e2c194d213a

The following commit(s) were added to refs/heads/main by this push:
     new 70c8299  Make failure logging more consistent.
70c8299 is described below

commit 70c829943a134519d0065483455c6e2c194d213a
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Nov 3 17:06:18 2022 -0400

    Make failure logging more consistent.
---
 .../authn/duo/impl/ValidateDuoTokenAuthenticationResult.java      | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
index 0da17a4..fdd2bcc 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
@@ -167,7 +167,7 @@ public class ValidateDuoTokenAuthenticationResult extends AbstractValidationActi
                 throw new DuoException("Authentication result object is null");
             }
         } catch (final ParseException | DuoException e) {
-            log.error("{} Duo 2FA access failed for '{}', auth_result missing",getLogPrefix(), username);
+            log.error("{} Duo 2FA authentication failed for '{}', auth_result missing",getLogPrefix(), username);
             handleError(profileRequestContext, authenticationContext,AuthnEventIds.AUTHN_EXCEPTION, 
                     AuthnEventIds.AUTHN_EXCEPTION);
             recordFailure(profileRequestContext);
@@ -192,21 +192,21 @@ public class ValidateDuoTokenAuthenticationResult extends AbstractValidationActi
                 recordSuccess(profileRequestContext);
                 return;
             } else if (DuoOIDCAuthAPI.DUO_AUTH_RESULT_DENY.equalsIgnoreCase(authResultStatus)) {
-                log.error("{} Duo 2FA failed for '{}', 2FA status '{}'",getLogPrefix(), username,
+                log.error("{} Duo 2FA authentication failed for '{}', 2FA status '{}'",getLogPrefix(), username,
                         authResultStatusMsg);
                 handleError(profileRequestContext, authenticationContext, authResultStatus,
                         AuthnEventIds.INVALID_CREDENTIALS);
                 recordFailure(profileRequestContext);
                 return;
             } else {        
-                log.error("{} Duo 2FA access failed for '{}', unknown response", getLogPrefix(), username);
+                log.error("{} Duo 2FA authentication failed for '{}', unknown response", getLogPrefix(), username);
                 handleError(profileRequestContext, authenticationContext,AuthnEventIds.AUTHN_EXCEPTION, 
                         AuthnEventIds.AUTHN_EXCEPTION);
                 recordFailure(profileRequestContext);
                 return;
             }
         } else {
-            log.error("{} Duo 2FA access failed for '{}', auth_results missing",getLogPrefix(), username);
+            log.error("{} Duo 2FA authentication failed for '{}', auth_results missing",getLogPrefix(), username);
             handleError(profileRequestContext, authenticationContext,AuthnEventIds.AUTHN_EXCEPTION, 
                     AuthnEventIds.AUTHN_EXCEPTION);
             recordFailure(profileRequestContext);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list