[JIRA] (JSATTR-7) PairwiseIdDataConnectorParser does not derive from the data connector parser base class
Rod Widdowson (Jira)
jira at shibboleth.atlassian.net
Thu Nov 3 10:25:45 UTC 2022
Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSATTR-7 ( https://shibboleth.atlassian.net/browse/JSATTR-7?atlOrigin=eyJpIjoiMmI5OWNlMmU4YTRiNDg5ZGFiMWNmODdlM2I2NzIzNGIiLCJwIjoiaiJ9 )
Re: PairwiseIdDataConnectorParser does not derive from the data connector parser base class ( https://shibboleth.atlassian.net/browse/JSATTR-7?atlOrigin=eyJpIjoiMmI5OWNlMmU4YTRiNDg5ZGFiMWNmODdlM2I2NzIzNGIiLCJwIjoiaiJ9 )
I’ll make sure that the three all align as part of this work.
>
>
>
> Based on what I see in the docs, seems like we must have intended it to
> support the common attributes.
>
>
Given that it will be hard to document things otherwise I’d agree - we would be better served to support them all and issue watrnings if they make no sense (e.g. failFast makes no sense on a computedIdConnector, so it could warn about it. But it should be an acceptable setting).
( https://shibboleth.atlassian.net/browse/JSATTR-7#add-comment?atlOrigin=eyJpIjoiMmI5OWNlMmU4YTRiNDg5ZGFiMWNmODdlM2I2NzIzNGIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSATTR-7#add-comment?atlOrigin=eyJpIjoiMmI5OWNlMmU4YTRiNDg5ZGFiMWNmODdlM2I2NzIzNGIiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:a51bb46 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221103/4327e92a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1d684721-5654-4eba-a15b-ae4a2226e99d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221103/4327e92a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-542fcd6a-bc22-41f2-b7e6-7a570db438cd
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221103/4327e92a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1ab738e3-31a9-4f75-afed-26a36ae7f798
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221103/4327e92a/attachment-0005.png>
More information about the commits
mailing list