[JIRA] (JSATTR-7) PairwiseIdDataConnectorParser does not derive from the data connector parser base class

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Wed Nov 2 17:16:27 UTC 2022


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSATTR-7 ( https://shibboleth.atlassian.net/browse/JSATTR-7?atlOrigin=eyJpIjoiMDQyNGExNGI3MGVjNGNkODg5MTAxM2ZlN2JlMWJiMmUiLCJwIjoiaiJ9 )

Re: PairwiseIdDataConnectorParser does not derive from the data connector parser base class ( https://shibboleth.atlassian.net/browse/JSATTR-7?atlOrigin=eyJpIjoiMDQyNGExNGI3MGVjNGNkODg5MTAxM2ZlN2JlMWJiMmUiLCJwIjoiaiJ9 )

I take that back. Adding the derivation from the data connector adds all sorts of extra requirements on the impl class (at least{{setFailFastInitialize(boolean) }} The code for the asbtract parser states that failfast

           // LDAP, Relational & HTTP only, limited in the schema

But unfortunately it isn’t. But thankfully we have a test for that. So that's another bug (we were silently ignoring the value)

So the work for 4.3 would be

* Add a `{{setFailFastInitialize(boolean) }} to the stored connector and immediately mark it deprecated
* Make the Computed ID parser inherit correctly

In V5 we

* remove the fastFailInitialize from the schema
* and make the Computed ID parser inherit correctly

( https://shibboleth.atlassian.net/browse/JSATTR-7#add-comment?atlOrigin=eyJpIjoiMDQyNGExNGI3MGVjNGNkODg5MTAxM2ZlN2JlMWJiMmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSATTR-7#add-comment?atlOrigin=eyJpIjoiMDQyNGExNGI3MGVjNGNkODg5MTAxM2ZlN2JlMWJiMmUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:cad9577 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221102/feed594c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0fca2f9b-3ddf-4db8-8112-1d751e98d7f9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221102/feed594c/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-5377e81c-0ce7-4382-8b00-2c4564b867c2
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221102/feed594c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7f3ed467-a670-44ac-8a4b-d26503bc1d67
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221102/feed594c/attachment-0005.png>


More information about the commits mailing list