[JIRA] (IDP-1473) Review and possibly remove CAS ticket dependency on IdPSession

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1473 ( https://shibboleth.atlassian.net/browse/IDP-1473?atlOrigin=eyJpIjoiOWQxYjBkMDBhYjkwNDRmYjlkYWE4OWQyNDY4OTAzY2UiLCJwIjoiaiJ9 )

Re: Review and possibly remove CAS ticket dependency on IdPSession ( https://shibboleth.atlassian.net/browse/IDP-1473?atlOrigin=eyJpIjoiOWQxYjBkMDBhYjkwNDRmYjlkYWE4OWQyNDY4OTAzY2UiLCJwIjoiaiJ9 )

Marvin Addison ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3Aa2eef653-9ef6-4d7f-b926-77ec80881594 ) I reviewed the patch for this, and my only comment is that per my comment from 2019 below, I would probably still suggest moving the UpdateIdPSessionWithSPSession action from the validate flow into the login flow so that it’s not required for the ticket to have an associated session to get it added. I don’t think you lose anything by doing that, and it preserves logout even when the session store isn’t server-side.

( https://shibboleth.atlassian.net/browse/IDP-1473#add-comment?atlOrigin=eyJpIjoiOWQxYjBkMDBhYjkwNDRmYjlkYWE4OWQyNDY4OTAzY2UiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1473#add-comment?atlOrigin=eyJpIjoiOWQxYjBkMDBhYjkwNDRmYjlkYWE4OWQyNDY4OTAzY2UiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:a877796 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221101/ee467c1a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-aaa8093c-2289-4456-a574-783a461fbb10
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221101/ee467c1a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ba175d8f-61aa-4e21-a6b3-7ea7a1f2df3e
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221101/ee467c1a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-04a8b4d9-6c72-47b2-8c82-3ae56ec6c0e8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221101/ee467c1a/attachment-0005.png>