[JIRA] (IDP-1955) Add attachClasses to the maven-war-plugin in idp-parent

[Dan McLaughlin (Jira)]

Dan McLaughlin ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A3a8d6dab-64f5-4a62-a23e-1603099d1796 ) *commented* on IDP-1955 ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMjRkMjBmM2FjZTI0NDgyM2E2NGU3MWYyMmQ4YmJhNDQiLCJwIjoiaiJ9 )

Re: Add attachClasses to the maven-war-plugin in idp-parent ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMjRkMjBmM2FjZTI0NDgyM2E2NGU3MWYyMmQ4YmJhNDQiLCJwIjoiaiJ9 )

Tom Zeller ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A0fa99aa9-d698-454c-a274-7a41bee6cef5 ) Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) I can’t stress enough how helpful this simple change would be for anyone that is making customizations to the IdP login page using a Maven build. In order to do something as simple as update the version of a third-party dependency we’d have to add overlay excludes and then manually define all the proper dependencies we wanted to replace in our pom. Now, with this change, we don’t have to do any of that. All I have to do was add the dependencies shown below to my project and the war was pulled in, all the dependencies, and anything I had defined in my dependencyManagement where I required a newer version of a dependency was automagically updated without me having to do anything special other than use the standard maven plugins to package and install our customized IdP war. It was so much simpler than it was when the only artifact available was a war because with a war Maven doesn’t do any resolution of dependencies. It’s not urgent to make the change if you need time to soak it in because for now, I’ve published my own version of the java-identity-provider to my local internal repository, but it would be nice in the future to go back to pointing to the public repositories.

<dependency>
<groupId>net.shibboleth.idp</groupId>
<artifactId>idp-war</artifactId>
<version>4.2.2-dan-SNAPSHOT</version>
<classifier>classes</classifier>
</dependency>
<dependency>
<groupId>net.shibboleth.idp</groupId>
<artifactId>idp-war-distribution</artifactId>
<version>4.2.2-dan-SNAPSHOT</version>
<classifier>classes</classifier>
</dependency>

On a separate note, I’ve never looked into how Shibboleth handles pull requests since it’s not available on Github, but do you have a process in place for people to submit pull requests outside of just opening tickets?

( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMjRkMjBmM2FjZTI0NDgyM2E2NGU3MWYyMmQ4YmJhNDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMjRkMjBmM2FjZTI0NDgyM2E2NGU3MWYyMmQ4YmJhNDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100198- sha1:b34c10a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220528/39ed178b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-dfa108dc-3884-4b47-8131-c3293147419a
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220528/39ed178b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a927fb82-84ab-41a2-8e79-6da7f409a2f7
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220528/39ed178b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4668c138-9397-4656-8e4a-19947041f457
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220528/39ed178b/attachment-0005.png>