[JIRA] (JOIDC-86) Facilitate login_hint sanitization

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-86 ( https://shibboleth.atlassian.net/browse/JOIDC-86?atlOrigin=eyJpIjoiODQ0NjBkNDNiMGE1NDc2ZmFlMjE4OTFjNTBmNTAwYWMiLCJwIjoiaiJ9 )

Re: Facilitate login_hint sanitization ( https://shibboleth.atlassian.net/browse/JOIDC-86?atlOrigin=eyJpIjoiODQ0NjBkNDNiMGE1NDc2ZmFlMjE4OTFjNTBmNTAwYWMiLCJwIjoiaiJ9 )

Actually the OP’s SWF action’s Java-code ( InitializeAuthenticationContext ) already has a setter for the login hint lookup strategy, there’s just no configuration property related to the setter. By default it points to DefaultRequestLoginHintLookupFunction that parses the value from request - supporting also the use of request object.

It might make sense just to change the bean declaration to contain something like  {{ p:loginHintLookupStrategy-ref="%

{idp.oidc.LoginHintLookupStrategy:DefaultRequestLoginHintLookupFunction}

" }}  to enable wiring of custom lookup functions. Or we could add a sanitiser function in between parsing and storing of the login_hint value inside this action.

( https://shibboleth.atlassian.net/browse/JOIDC-86#add-comment?atlOrigin=eyJpIjoiODQ0NjBkNDNiMGE1NDc2ZmFlMjE4OTFjNTBmNTAwYWMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-86#add-comment?atlOrigin=eyJpIjoiODQ0NjBkNDNiMGE1NDc2ZmFlMjE4OTFjNTBmNTAwYWMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:666e164 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220331/17749c7b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-d5cb0342-8ea9-454c-9e48-f536f6c1af22
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220331/17749c7b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f424306b-49b7-4813-8da3-93ba7a473b62
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220331/17749c7b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-05e53c73-a864-47f0-80fd-f8d29c19fc3a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220331/17749c7b/attachment-0005.png>