[JIRA] (IDP-1926) CSS files should be treated as text on installation
Ian Young (Jira)
jira at shibboleth.atlassian.net
Wed Mar 30 06:46:12 UTC 2022
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on IDP-1926 ( https://shibboleth.atlassian.net/browse/IDP-1926?atlOrigin=eyJpIjoiYTFiMTIwYjEyZDcwNGYxMjgwMzZkMzc4MGIyMmRiOGYiLCJwIjoiaiJ9 )
Re: CSS files should be treated as text on installation ( https://shibboleth.atlassian.net/browse/IDP-1926?atlOrigin=eyJpIjoiYTFiMTIwYjEyZDcwNGYxMjgwMzZkMzc4MGIyMmRiOGYiLCJwIjoiaiJ9 )
Interestingly, the assembly descriptor for the.tar.gz file (which is what, as a Linux user, I’m using) doesn’t control line endings at all, but assumes everything is LF-style in the Git repository.
The placeholder.css file seems to have been checked in with CRLF line endings.
Fixed that in commit 6ebd574dd10a393794ab6a594db8e22a9fafa6f8.
Scott’s previous commit fd25a42ac58f85afcbf567c2ac3d0cd2fdd4b18c should ensure that they end up with CRLFs for Windows installs via the.zip assembly.
I’ll leave this open until I can confirm against the next nightly.
( https://shibboleth.atlassian.net/browse/IDP-1926#add-comment?atlOrigin=eyJpIjoiYTFiMTIwYjEyZDcwNGYxMjgwMzZkMzc4MGIyMmRiOGYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1926#add-comment?atlOrigin=eyJpIjoiYTFiMTIwYjEyZDcwNGYxMjgwMzZkMzc4MGIyMmRiOGYiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:666e164 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220330/44028dd3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e0bbdfe7-03a2-4936-83f0-d8c8fd700fe2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220330/44028dd3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7ce45387-5de6-4f60-960d-d0479aac2765
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220330/44028dd3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-25405367-9246-4f00-8644-34dea3433da4
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220330/44028dd3/attachment-0005.png>
More information about the commits
mailing list