[JIRA] (JOIDCRP-14) Client Identifier Resolution

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JOIDCRP-14 ( https://shibboleth.atlassian.net/browse/JOIDCRP-14?atlOrigin=eyJpIjoiOTQzOGY2MGE5ZTM4NDZkOGFmYjBkM2ExNGJjODlhMjQiLCJwIjoiaiJ9 )

Re: Client Identifier Resolution ( https://shibboleth.atlassian.net/browse/JOIDCRP-14?atlOrigin=eyJpIjoiOTQzOGY2MGE5ZTM4NDZkOGFmYjBkM2ExNGJjODlhMjQiLCJwIjoiaiJ9 )

As Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) pointed out, having another resolver service for this was unnecessary, instead, adding the logic via a strategy to the profile configuration (which is already a reloadable service). This is now done using the following logic:

* By default, the client identifier lookup strategy constructs a client_id value from that provided in the oidc properties file. This allows quick configuration if there is only a single client.
* If there is more than one client e.g. some kind of discovery flow is used to choose the OP, the client_id property value can be commented out, and the strategy will use a further embedded strategy to lookup the client identifier from the given issuer_id of the chosen OP.

* The default strategy for this is backed by a storage service. Currently, an in-memory service is constructed from the same map as shown in https://shibboleth.atlassian.net/browse/JOIDCRP-14?focusedCommentId=32416. This would need to be added to the relying party XML by the deployer.

* This can also be overridden by specifying a client_id in a RelyingPartyOverrides profile bean for an OP. This is arguably better than having to add the map into the relying-party.xml. Although it would mean adding an override for every OP if you are dealing with more than one.

( https://shibboleth.atlassian.net/browse/JOIDCRP-14#add-comment?atlOrigin=eyJpIjoiOTQzOGY2MGE5ZTM4NDZkOGFmYjBkM2ExNGJjODlhMjQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDCRP-14#add-comment?atlOrigin=eyJpIjoiOTQzOGY2MGE5ZTM4NDZkOGFmYjBkM2ExNGJjODlhMjQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:838a6ed )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220324/57700b83/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f6021787-9992-4bb3-a3a4-b5c64e868ccd
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220324/57700b83/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8875c245-a6b9-43f8-a5ee-a7854a087f83
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220324/57700b83/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-93ae9bf8-b12a-4fc5-981e-31ea7ef46de3
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220324/57700b83/attachment-0005.png>