[java-idp-plugin-oidc-rp] branch main updated: Cleanup log statements

Phil Smart philip.smart at jisc.ac.uk
Thu Mar 24 10:28:21 UTC 2022


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=f67b573037b5e83afac568bcb8845c51330d2c77

The following commit(s) were added to refs/heads/main by this push:
     new f67b573  Cleanup log statements
f67b573 is described below

commit f67b573037b5e83afac568bcb8845c51330d2c77
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Mar 24 10:28:14 2022 +0000

    Cleanup log statements
---
 .../authn/oidc/rp/decoding/impl/DefaultMapResponseDecoder.java       | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultMapResponseDecoder.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultMapResponseDecoder.java
index 3a66ff2..19d0363 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultMapResponseDecoder.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultMapResponseDecoder.java
@@ -44,13 +44,12 @@ public class DefaultMapResponseDecoder extends AbstractJSONResponseDecoderFuncti
         try {
             final int httpStatusCode = httpResponse.getStatusLine().getStatusCode();
             if (httpStatusCode != HttpStatus.SC_OK) {
+                log.warn("Non-ok status code ({}) returned from HTTP endpoint", httpStatusCode);
                 //dump the body for logging - if one exists
                 if (httpResponse.getEntity() != null && httpResponse.getEntity().getContent() != null) {
                     final String errorContent = IOUtils.readInputStreamToString(httpResponse.getEntity().getContent());
                     log.error("HTTP endpoint returned a Non-ok message of '{}'",errorContent);
-                }
-                log.warn("Non-ok status code ({}) returned from HTTP endpoint: {}", httpStatusCode, 
-                        httpResponse.getStatusLine().getReasonPhrase());
+                }               
                 return null;
             } else if (httpResponse.getEntity() == null || httpResponse.getEntity().getContent() == null) {
                 log.warn("HTTP response does not contain a message entity, nothing to decode");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list