[java-idp-plugin-metadatagen] branch main updated: JMETAGEN-3 Test Failures under Linux (ok on Windows)

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-idp-plugin-metadatagen.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-metadatagen.git;a=commit;h=502238593317e03f1c3f1c73c14401abce57d76c

The following commit(s) were added to refs/heads/main by this push:
     new 5022385  JMETAGEN-3 Test Failures under Linux (ok on Windows)
5022385 is described below

commit 502238593317e03f1c3f1c73c14401abce57d76c
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Mar 21 13:41:17 2022 +0000

    JMETAGEN-3 Test Failures under Linux (ok on Windows)
    
    https://shibboleth.atlassian.net/browse/JMETAGEN-3
    
    Default test off.  Add instructions on how to turn the test on
    and bring in some extra logging.
---
 .../metadatagen/impl/MetadataGenParameters.java       |  7 +++++++
 .../idp/plugin/metadatagen/impl/MetadataGenTest.java  | 10 ++++++----
 metadatagen-impl/src/test/resources/logback-test.xml  | 19 +++++++++++++++++++
 3 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenParameters.java b/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenParameters.java
index 386239e..eb1e24f 100644
--- a/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenParameters.java
+++ b/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenParameters.java
@@ -26,6 +26,8 @@ import java.util.List;
 
 import javax.annotation.Nullable;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.core.io.Resource;
 
 import net.shibboleth.utilities.java.support.component.AbstractInitializableComponent;
@@ -66,6 +68,9 @@ public class MetadataGenParameters extends AbstractInitializableComponent {
      */
     private List<String> signingCerts;
 
+    /** Log */
+    private Logger log = LoggerFactory.getLogger(MetadataGenParameters.class);
+
     /** {@inheritDoc} */
     protected void doInitialize() throws ComponentInitializationException {
         try {
@@ -118,6 +123,7 @@ public class MetadataGenParameters extends AbstractInitializableComponent {
         try {
             signingCert = resource.getFile();
         } catch (final IOException e) {
+	    log.error("Could not locate signing certificates at {}", resource, e);
             signingCert = null;
         }
     }
@@ -152,6 +158,7 @@ public class MetadataGenParameters extends AbstractInitializableComponent {
             try {
                 backChannelCert = resource.getFile();
             } catch (final IOException e) {
+                log.error("Could not locate bach channel certificates at {}", resource, e);
                 backChannelCert = null;
             }
         }
diff --git a/metadatagen-impl/src/test/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenTest.java b/metadatagen-impl/src/test/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenTest.java
index ed0b35a..845cf08 100644
--- a/metadatagen-impl/src/test/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenTest.java
+++ b/metadatagen-impl/src/test/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenTest.java
@@ -38,10 +38,12 @@ import net.shibboleth.ext.spring.cli.AbstractCommandLine;
 @SuppressWarnings("javadoc")
 public class MetadataGenTest {
 	
-	//  Set the next three up to run the test
-	private final static String IDP_HOME =  "H:/Downloads/idp";
-	
-	private final boolean enabled = true;
+    // To run the test
+    //   1) Set the next two static fields
+    //   2) Edit the setting of the property 'idp.metadata.backchannel.cert' in
+    //      src/test/resources/net/shibboleth/idp/plugin/metadatagen/impl/extra2
+    private final static String IDP_HOME =  "H:/Downloads/idp";
+    private final boolean enabled = false;
 	
     @Test(enabled = enabled) public void test() throws IOException {
         assertEquals(MetadataGenCLI.runMain(
diff --git a/metadatagen-impl/src/test/resources/logback-test.xml b/metadatagen-impl/src/test/resources/logback-test.xml
new file mode 100644
index 0000000..a58ce3f
--- /dev/null
+++ b/metadatagen-impl/src/test/resources/logback-test.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<configuration>
+    <logger name="net.shibboleth" level="ALL"/>
+    <logger name="org.springframework" level="DEBUG"/>
+
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+            <pattern>%level [%logger:%line] - %msg%n</pattern>
+            <charset>UTF-8</charset>
+        </encoder>
+    </appender>
+
+    <root>
+        <level value="ALL" />
+        <appender-ref ref="STDOUT" />
+    </root>
+    
+</configuration>
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.