[JIRA] (IDP-1920) Attribute release activation condition is SAML-specific.

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1920 ( https://shibboleth.atlassian.net/browse/IDP-1920?atlOrigin=eyJpIjoiYmY2Nzg0YWQxOGY1NDI2OTgyMzRkNTBiMjc5NTE1NTYiLCJwIjoiaiJ9 )

Re: Attribute release activation condition is SAML-specific. ( https://shibboleth.atlassian.net/browse/IDP-1920?atlOrigin=eyJpIjoiYmY2Nzg0YWQxOGY1NDI2OTgyMzRkNTBiMjc5NTE1NTYiLCJwIjoiaiJ9 )

I guess the original thought was: If we’re not checking the consent record in the query flow, then it’s ok to enable consent as long as it’s not per-attribute because the query flow will just re-resolve the same data as it just did and got consent for, and if the user declines, there wouldn’t be a query. That’s all somewhat dubious but I guess somewhat logical.

But I think that became moot with the addition of the check into the query flow. We never changed the condition at that point, but I think we should have, and I think the solution might be to rip all of that out, leave the deployer condition as the only check, and just make sure we implement the missing code in the cases it’s missing, which is basically CAS for the moment.

( https://shibboleth.atlassian.net/browse/IDP-1920#add-comment?atlOrigin=eyJpIjoiYmY2Nzg0YWQxOGY1NDI2OTgyMzRkNTBiMjc5NTE1NTYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1920#add-comment?atlOrigin=eyJpIjoiYmY2Nzg0YWQxOGY1NDI2OTgyMzRkNTBiMjc5NTE1NTYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:81e20ed )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220314/67cb58c0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-42a23763-0992-4f66-ac64-323e98bd7520
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220314/67cb58c0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8d25132d-5dfc-4876-b7fb-85e4949760af
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220314/67cb58c0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b7424b45-0a3e-44d9-84fe-119427e4a2d9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220314/67cb58c0/attachment-0005.png>