[java-idp-oidc] branch main updated: JOIDC-21 - Use token authentication for OIDC dynamic client registration

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=ffb587e40b6d5a8379982cf607905c3c8aa89748

The following commit(s) were added to refs/heads/main by this push:
     new ffb587e4 JOIDC-21 - Use token authentication for OIDC dynamic client registration
ffb587e4 is described below

commit ffb587e40b6d5a8379982cf607905c3c8aa89748
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Mar 9 17:13:36 2022 +0200

    JOIDC-21 - Use token authentication for OIDC dynamic client registration
    
    https://shibboleth.atlassian.net/browse/JOIDC-21
    
    Read the metadata policy resource from the PRC (obtained via HttpServletRequest)
    instead of request parameters.
---
 .../issue-registration-access-token-beans.xml       | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/oidc/issue-registration-access-token/issue-registration-access-token-beans.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/oidc/issue-registration-access-token/issue-registration-access-token-beans.xml
index 02c80503..320a0391 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/oidc/issue-registration-access-token/issue-registration-access-token-beans.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/oidc/issue-registration-access-token/issue-registration-access-token-beans.xml
@@ -68,14 +68,17 @@
         class="net.shibboleth.oidc.metadata.cache.impl.DefaultJSONMapParsingStrategy"
         c:valueClass="net.shibboleth.oidc.metadata.policy.MetadataPolicy"/>
 
-    <bean id="shibboleth.oidc.admin.CriteriaToIdentifierStrategy"
-       parent="shibboleth.Functions.Expression" p:customObject-ref="shibboleth.HttpServletRequest"
-       c:expression="#custom.getParameter(T(net.shibboleth.idp.plugin.oidc.op.cli.IssueRegistrationAccessTokenArguments).URL_PARAM_METADATA_POLICY_LOCATION)" />
+    <bean id="shibboleth.oidc.admin.MetadataPolicyIdentifierStrategy" parent="shibboleth.Functions.Compose">
+        <constructor-arg name="g">
+            <bean class="net.shibboleth.idp.plugin.oidc.op.profile.logic.DefaultMetadataPolicyLocationLookupFunction" />
+        </constructor-arg>
+        <constructor-arg name="f">
+            <bean parent="shibboleth.Functions.Expression"
+                p:customObject-ref="shibboleth.HttpServletRequest"
+                c:expression="#custom.getAttribute('opensamlProfileRequestContext')" />
+        </constructor-arg>
+    </bean>
 
-    <bean id="shibboleth.oidc.admin.MetadataPolicyIdentifierExtractionStrategy"
-       parent="shibboleth.Functions.Expression" p:customObject-ref="shibboleth.HttpServletRequest"
-       c:expression="#custom.getParameter(T(net.shibboleth.idp.plugin.oidc.op.cli.IssueRegistrationAccessTokenArguments).URL_PARAM_METADATA_POLICY_LOCATION)" />
-        
     <bean id="fetchThroughCacheFactory" class="net.shibboleth.oidc.metadata.cache.impl.FetchThroughMetadataCacheBuilder$Builder"/>
     
     <bean id="shibboleth.oidc.admin.CacheBuilder" factory-bean="fetchThroughCacheFactory" factory-method="build"
@@ -84,8 +87,8 @@
     <bean class="net.shibboleth.oidc.metadata.cache.impl.FetchThroughMetadataCacheBuilderSpec"
         id="shibboleth.oidc.admin.BaseCacheBuilderSpec" abstract="true"
         p:fetchStrategy-ref="shibboleth.oidc.admin.MetadataPolicyFetchingStrategy"
-        p:criteriaToIdentifierStrategy-ref="shibboleth.oidc.admin.CriteriaToIdentifierStrategy"
-        p:identifierExtractionStrategy-ref="shibboleth.oidc.admin.MetadataPolicyIdentifierExtractionStrategy"
+        p:criteriaToIdentifierStrategy-ref="shibboleth.oidc.admin.MetadataPolicyIdentifierStrategy"
+        p:identifierExtractionStrategy-ref="shibboleth.oidc.admin.MetadataPolicyIdentifierStrategy"
        />
 
     <bean id="shibboleth.oidc.admin.MetadataPolicyFetchingStrategy"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.