[JIRA] (JMVN-26) Distribution signature checked cannot handle versions with dashes

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Maven Enforcer ( https://shibboleth.atlassian.net/browse/JMVN?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JMVN-26?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 ) JMVN-26 ( https://shibboleth.atlassian.net/browse/JMVN-26?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 ) Distribution signature checked cannot handle versions with dashes ( https://shibboleth.atlassian.net/browse/JMVN-26?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 3,1.0 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Created: 05/Mar/22 10:15 AM Fix Versions: 3.1.1 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

When we scan a distribution to do a signature check we “just” scan back from the end of the file to the first '-' and call that the version.

This dies horribly with versions with '-' in them (like logback-access-1.3.0-alpha-14

We can make things better by carrying on going backwards until we find an artifact ID we know about (or there are not more '-' left.

( https://shibboleth.atlassian.net/browse/JMVN-26#add-comment?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JMVN-26#add-comment?atlOrigin=eyJpIjoiMDliZjE2YzBkZmRkNGNmMzllNjZjOTBmMTFkZDFiNDgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100195- sha1:2787fd6 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220305/7f9b619e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-618f3a3f-3d8f-43d2-bd35-e3df4cd87ecb
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220305/7f9b619e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-f74286a5-e723-4b07-9fa7-1cee6745f009
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220305/7f9b619e/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e6ccf786-06dd-43b1-9817-200404917e08
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220305/7f9b619e/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c7eb1e64-241b-4248-a006-9768298e6e92
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220305/7f9b619e/attachment-0007.png>