[JIRA] (JSPT-115) Inconsistent contracts in constructors of ContextHandlingHttpClient

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSPT-115 ( https://shibboleth.atlassian.net/browse/JSPT-115?atlOrigin=eyJpIjoiZTcxOTliMzNkM2M1NGIxN2JlYTljMzdhOWI0NjA3ZjgiLCJwIjoiaiJ9 )

Re: Inconsistent contracts in constructors of ContextHandlingHttpClient ( https://shibboleth.atlassian.net/browse/JSPT-115?atlOrigin=eyJpIjoiZTcxOTliMzNkM2M1NGIxN2JlYTljMzdhOWI0NjA3ZjgiLCJwIjoiaiJ9 )

I’ve tried the proposed fix (enforce @Nonnull and fix the other constructor to pass List.of() ) and nothing in the stack seems to fail as a result.

I will wait until the upcoming version number bumps have happened before committing anything.

( https://shibboleth.atlassian.net/browse/JSPT-115#add-comment?atlOrigin=eyJpIjoiZTcxOTliMzNkM2M1NGIxN2JlYTljMzdhOWI0NjA3ZjgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-115#add-comment?atlOrigin=eyJpIjoiZTcxOTliMzNkM2M1NGIxN2JlYTljMzdhOWI0NjA3ZjgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100194- sha1:533b55a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/aeb7b896/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-966802c7-25e4-4b6b-8a19-0596c14fa418
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/aeb7b896/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-69144dc0-e6b2-40b6-9020-9756869e25c9
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/aeb7b896/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-1d3618d4-c60a-4286-bfd8-e420c51c85c3
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/aeb7b896/attachment-0005.png>