[java-identity-provider] branch main updated: IDP-1915 Install logger doesn't handle logging arguments

Rod Widdowson rdw at steadingsoftware.com
Wed Mar 2 14:21:50 UTC 2022


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=be09318c3f72f809ab64778a9bc950cfa2d1ed40

The following commit(s) were added to refs/heads/main by this push:
     new be09318c3 IDP-1915 Install logger doesn't handle logging arguments
be09318c3 is described below

commit be09318c3f72f809ab64778a9bc950cfa2d1ed40
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Mar 2 14:18:59 2022 +0000

    IDP-1915 Install logger doesn't handle logging arguments
    
    https://shibboleth.atlassian.net/browse/IDP-1915
    
    The code should be converting {} to %s, but one case
    (warn(String, Object...)) was missing.
---
 .../java/net/shibboleth/idp/installer/impl/InstallationLogger.java     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallationLogger.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallationLogger.java
index a591a563a..8f069db89 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallationLogger.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallationLogger.java
@@ -315,8 +315,7 @@ public final class InstallationLogger implements Logger {
         if (encapsulated.isDebugEnabled()) {
             encapsulated.warn(format, arguments);
         }
-        System.out.format(format, arguments);
-        System.out.println();
+        format(format, arguments);
     }
 
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list