[JIRA] (IDP-1915) Install logger doesn't handle logging arguments

Scott Cantor (Jira) jira at shibboleth.atlassian.net
Wed Mar 2 14:01:30 UTC 2022


Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-1915?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 ) IDP-1915 ( https://shibboleth.atlassian.net/browse/IDP-1915?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 ) Install logger doesn't handle logging arguments ( https://shibboleth.atlassian.net/browse/IDP-1915?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.1.0, 4.1.1, 4.1.2, 4.1.3, 4.1.4, 4.1.5 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Installer, Logging and Metrics Created: 02/Mar/22 9:01 AM Fix Versions: 4.2.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The “wrapping” of the logging in the installer is not able to handle the slf4j-style {} argument strings, it seems to want %s-style formatting.

e.g “Installed Plugin {} version {} is not supported with IdP Version {}, continuing.”

The placeholders don’t get handled on the copy sent to stdout since that’s running through the format call and not the logging API.

( https://shibboleth.atlassian.net/browse/IDP-1915#add-comment?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1915#add-comment?atlOrigin=eyJpIjoiM2NmZWMyYTcyOTk5NDhmMGJiOWMyZTFlMzcyOTgwMWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100194- sha1:533b55a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/c24f044d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-085606d7-b422-4a16-8093-7e44b2e84350
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/c24f044d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b1cc269b-3caa-4029-836d-c27a54627621
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/c24f044d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4db89938-2ca8-4b72-9112-546bbd710eb7
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/c24f044d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c53b876d-37eb-4e7b-a5eb-51124dbd7e73
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220302/c24f044d/attachment-0007.png>


More information about the commits mailing list