[java-idp-plugin-metadatagen] branch main updated: JMETAGEN-2 metadatagen emits invalid MDUI XML

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-idp-plugin-metadatagen.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-metadatagen.git;a=commit;h=168696df4c51ce8c9a7b2a76a92c65c3fcc5d61c

The following commit(s) were added to refs/heads/main by this push:
     new 168696d  JMETAGEN-2 metadatagen emits invalid MDUI XML
168696d is described below

commit 168696df4c51ce8c9a7b2a76a92c65c3fcc5d61c
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Mar 1 20:03:01 2022 +0000

    JMETAGEN-2 metadatagen emits invalid MDUI XML
    
    https://shibboleth.atlassian.net/browse/JMETAGEN-2
    
    Fix closing of MDUI elements
---
 .../shibboleth/idp/plugin/metadatagen/impl/MetadataGenCLI.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenCLI.java b/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenCLI.java
index 59e1d1d..b3039e7 100644
--- a/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenCLI.java
+++ b/metadatagen-impl/src/main/java/net/shibboleth/idp/plugin/metadatagen/impl/MetadataGenCLI.java
@@ -172,7 +172,7 @@ public final class MetadataGenCLI extends AbstractIdPHomeAwareCommandLine<Metada
         final Environment env = getApplicationContext().getEnvironment();
         final String displayName = env.getProperty(MetadataGenCommandLineArguments.MDUI_DISPLAY_NAME_PREFIX+lang);
         if (displayName != null) {
-            output.format("            <%s:%s %s:%s=\"%s\">%s<%s:%s>\n",
+            output.format("            <%s:%s %s:%s=\"%s\">%s</%s:%s>\n",
                     SAMLConstants.SAML20MDUI_PREFIX, DisplayName.DEFAULT_ELEMENT_LOCAL_NAME,
                     XMLConstants.XML_PREFIX, LangBearing.XML_LANG_ATTR_LOCAL_NAME,
                     lang, displayName,
@@ -180,7 +180,7 @@ public final class MetadataGenCLI extends AbstractIdPHomeAwareCommandLine<Metada
         }
         final String description = env.getProperty(MetadataGenCommandLineArguments.MDUI_DESCRIPTION_PREFIX+lang);
         if (description != null) {
-            output.format("            <%s:%s %s:%s=\"%s\">%s<%s:%s>\n",
+            output.format("            <%s:%s %s:%s=\"%s\">%s</%s:%s>\n",
                     SAMLConstants.SAML20MDUI_PREFIX, Description.DEFAULT_ELEMENT_LOCAL_NAME,
                     XMLConstants.XML_PREFIX, LangBearing.XML_LANG_ATTR_LOCAL_NAME,
                     lang, description,
@@ -211,11 +211,11 @@ public final class MetadataGenCLI extends AbstractIdPHomeAwareCommandLine<Metada
             final String mduiLangs = env.getProperty(MetadataGenCommandLineArguments.MDUI_LANGS_PROPERTY);
             if (mduiLangs == null) {
                 output.format("\n<!--\n          Fill in the details for your IdP here\n\n");
-                output.format("            <%s:%s %s:%s=\"en\">A Name for the IdP<%s:%s>\n",
+                output.format("            <%s:%s %s:%s=\"en\">A Name for the IdP</%s:%s>\n",
                         SAMLConstants.SAML20MDUI_PREFIX, DisplayName.DEFAULT_ELEMENT_LOCAL_NAME,
                         XMLConstants.XML_PREFIX, LangBearing.XML_LANG_ATTR_LOCAL_NAME,
                         SAMLConstants.SAML20MDUI_PREFIX, DisplayName.DEFAULT_ELEMENT_LOCAL_NAME);
-                output.format("            <%s:%s %s:%s=\"en\">A Description for the IdP<%s:%s>\n",
+                output.format("            <%s:%s %s:%s=\"en\">A Description for the IdP</%s:%s>\n",
                         SAMLConstants.SAML20MDUI_PREFIX, Description.DEFAULT_ELEMENT_LOCAL_NAME,
                         XMLConstants.XML_PREFIX, LangBearing.XML_LANG_ATTR_LOCAL_NAME,
                         SAMLConstants.SAML20MDUI_PREFIX, Description.DEFAULT_ELEMENT_LOCAL_NAME);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.