[JIRA] (JOIDC-51) Need to populate an SPSession for each OIDC RP accessed

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-51 ( https://shibboleth.atlassian.net/browse/JOIDC-51?atlOrigin=eyJpIjoiYTA1N2Q1MjFmZmNkNDFlZGIxNzg0NTgyOGVmODExOTgiLCJwIjoiaiJ9 )

Re: Need to populate an SPSession for each OIDC RP accessed ( https://shibboleth.atlassian.net/browse/JOIDC-51?atlOrigin=eyJpIjoiYTA1N2Q1MjFmZmNkNDFlZGIxNzg0NTgyOGVmODExOTgiLCJwIjoiaiJ9 )

It seems that the existing codebase for SAML is also able to create a BasicSPSession for the OIDC RPs.

If the authorize-flow evaluats the following bean (exactly the same definition in flows/saml/saml2/sso-abstract-beans.xml )

   <bean id="UpdateSessionWithSPSession"
           class="net.shibboleth.idp.session.impl.UpdateSessionWithSPSession" scope="prototype"
           p:activationCondition="%{idp.session.trackSPSessions:false}"
           p:sessionManager-ref="shibboleth.SessionManager">
       <property name="SPSessionCreationStrategy">
           <bean class="net.shibboleth.idp.saml.session.impl.SAML2SPSessionCreationStrategy"
               c:lifetime="%{idp.session.defaultSPlifetime:PT2H}"/>
       </property>
   </bean>

SAML2SPSessionCreationStrategy seems to create a *BasicSPSession* that contains client_id of RP as the id.

I also verified that OIDC RP appears in the logout page after this change.

Does this sound acceptable before a proper OIDC Logout support? Obviously we could also create a new *OIDCRPSession* as proposed in the description, but the contents at this phase would probably be equal or very close to BasicSPSession.

( https://shibboleth.atlassian.net/browse/JOIDC-51#add-comment?atlOrigin=eyJpIjoiYTA1N2Q1MjFmZmNkNDFlZGIxNzg0NTgyOGVmODExOTgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-51#add-comment?atlOrigin=eyJpIjoiYTA1N2Q1MjFmZmNkNDFlZGIxNzg0NTgyOGVmODExOTgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:31e1add )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/5bb97ef1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-81a24861-606c-4b9c-bc89-e4d2ff9590fa
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/5bb97ef1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-28de8b09-7459-410d-9fe6-b347a09467f5
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/5bb97ef1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-7bc89c02-90d2-4fd3-8aa2-f7587bc012ce
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/5bb97ef1/attachment-0005.png>