[JIRA] (JOIDC-71) Lack of openid scope in metadata doesn't prevent id_token issuance

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-71 ( https://shibboleth.atlassian.net/browse/JOIDC-71?atlOrigin=eyJpIjoiNDU3NWQwZDVjMWMxNGE2OTliM2NmN2M2MTEwZTYyZWQiLCJwIjoiaiJ9 )

Re: Lack of openid scope in metadata doesn't prevent id_token issuance ( https://shibboleth.atlassian.net/browse/JOIDC-71?atlOrigin=eyJpIjoiNDU3NWQwZDVjMWMxNGE2OTliM2NmN2M2MTEwZTYyZWQiLCJwIjoiaiJ9 )

Added an activation condition to the actions dealing with id_token generation in the token flow. id_token is now only generated and returned if the validated scope (request verified against scope in the metadata) contains openid.

Also added flow tests to make sure that authorize-flow returns error if openid is not part of the requested scope. The Nimbus decoder requires the scope to exist as it assumes to parse OIDC authentication requests. This should be refactored if we want to support more generic OAuth2 authorization requests.

( https://shibboleth.atlassian.net/browse/JOIDC-71#add-comment?atlOrigin=eyJpIjoiNDU3NWQwZDVjMWMxNGE2OTliM2NmN2M2MTEwZTYyZWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-71#add-comment?atlOrigin=eyJpIjoiNDU3NWQwZDVjMWMxNGE2OTliM2NmN2M2MTEwZTYyZWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:31e1add )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/ff197cfd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-fcb8d0f0-2566-4cb9-bb5e-a9910aabcd46
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/ff197cfd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-58f118c3-1989-477b-87e9-ad3eb8a12f62
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/ff197cfd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-cf218d66-ef67-41e6-8d0f-eb8b7c2b264e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/ff197cfd/attachment-0005.png>