[JIRA] (IDP-1912) metadatagen emits invalid MDUI XML

[Matthew Slowe (Jira)]

Matthew Slowe ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5c45da4b23f5bf67262143c7 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-1912?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 ) IDP-1912 ( https://shibboleth.atlassian.net/browse/IDP-1912?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 ) metadatagen emits invalid MDUI XML ( https://shibboleth.atlassian.net/browse/IDP-1912?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.1.5 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: Metadata Created: 01/Mar/22 5:32 AM Environment:
# ./bin/version.sh
4.1.5
# ./bin/plugin.sh -l
Plugin: net.shibboleth.idp.plugin.metadatagen	Current Version: 1.0.0
Priority: Trivial Reporter: Matthew Slowe ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5c45da4b23f5bf67262143c7 )

# ./bin/metadatagen.sh  -o /tmp/out.xml
# xmllint /tmp/out.xml
/tmp/out.xml:20: parser error : Opening and ending tag mismatch: Description line 18 and UIInfo
         </mdui:UIInfo>
                       ^
/tmp/out.xml:22: parser error : Opening and ending tag mismatch: Description line 18 and Extensions
       </Extensions>
                    ^
/tmp/out.xml:92: parser error : Opening and ending tag mismatch: DisplayName line 17 and IDPSSODescriptor
   </IDPSSODescriptor>
                      ^
/tmp/out.xml:93: parser error : Opening and ending tag mismatch: DisplayName line 17 and EntityDescriptor
</EntityDescriptor>
                  ^
/tmp/out.xml:94: parser error : Premature end of data in tag UIInfo line 16

^

The <mdui:DisplayName> and <mdui:Description> closing tags are missing a /. Diff to correct out.xml is:

# diff /tmp/out.xml /tmp/out-fixed.xml
--- /tmp/out.xml
+++ /tmp/out-fixed.xml
@@ -14,8 +14,8 @@
        <Extensions>
          <shibmd:Scope regexp="false">exmaple.ac.uk</shibmd:Scope>
          <mdui:UIInfo>
-            <mdui:DisplayName xml:lang="en">Example University<mdui:DisplayName>
-            <mdui:Description xml:lang="en">The University of Example, United Kingdom<mdui:Description>
+            <mdui:DisplayName xml:lang="en">Example University</mdui:DisplayName>
+            <mdui:Description xml:lang="en">The University of Example, United Kingdom</mdui:Description>
            <mdui:Logo height="80" width="60">https://idp.example.ac.uk/logo.png</mdui:Logo>
          </mdui:UIInfo>

( https://shibboleth.atlassian.net/browse/IDP-1912#add-comment?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1912#add-comment?atlOrigin=eyJpIjoiNzJhOTI0NTBmN2NjNDI3OWEyZjBmYjk3ZmI3YmM0NGEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:31e1add )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/95e2fe1f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0c09060c-d0d4-41be-b53f-dc21c891e268
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/95e2fe1f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-6c7674c4-5e1d-411e-b257-51036c192e5a
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/95e2fe1f/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-fe39cffe-53be-4033-80b4-3e03a2e1c5bb
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/95e2fe1f/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-23b81598-84e7-43c2-a104-468fe2595824
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220301/95e2fe1f/attachment-0007.png>