[JIRA] (OSJ-354) Suffix the PROTOCOL_MESSAGE category with .SAML

[Brent Putman (Jira)]

Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *commented* on OSJ-354 ( https://shibboleth.atlassian.net/browse/OSJ-354?atlOrigin=eyJpIjoiMmRkNTg4YzNkN2RlNDJkYjg1MjlkYmIzYjMxYzQ4YzMiLCJwIjoiaiJ9 )

Re: Suffix the PROTOCOL_MESSAGE category with .SAML ( https://shibboleth.atlassian.net/browse/OSJ-354?atlOrigin=eyJpIjoiMmRkNTg4YzNkN2RlNDJkYjg1MjlkYmIzYjMxYzQ4YzMiLCJwIjoiaiJ9 )

This seems like a good idea.

Implementing it is slightly more complicated than I first thought. The encoder and decoder base classes that use this category are up in the messaging-api module, and are not SAML-specific. So will have to devise a mechanism whereby the relevant SAML subclasses (either abstract or concrete, not sure yet) make a call to a new method to set the logger category on the base class where the logging is actually done.

And in the soap-impl module the main SOAP decoding/encoding logic is there and are not SAML-specific, so those should probably set “.SOAP”, but then their SAML-specific subclasses would further override to do “.SAML” instread.

( https://shibboleth.atlassian.net/browse/OSJ-354#add-comment?atlOrigin=eyJpIjoiMmRkNTg4YzNkN2RlNDJkYjg1MjlkYmIzYjMxYzQ4YzMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-354#add-comment?atlOrigin=eyJpIjoiMmRkNTg4YzNkN2RlNDJkYjg1MjlkYmIzYjMxYzQ4YzMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:c6c9d1f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220630/526b0af6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-388ca04b-d0e6-488e-a807-f7001e84c272
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220630/526b0af6/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-db8aeaac-fce6-4190-be91-d20483c6fd2c
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220630/526b0af6/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a7098631-7284-49ce-abdf-306a5bb837a4
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220630/526b0af6/attachment-0005.png>