[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiZmRhZjBiYmU2ZWQ4NGY4MDhmOTFmZWYzMGIxY2QwMTkiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiZmRhZjBiYmU2ZWQ4NGY4MDhmOTFmZWYzMGIxY2QwMTkiLCJwIjoiaiJ9 )

This might have a wider implication for the IdP (we’ll find out when I get to the spring bit).

It all dies because of this code in ResolverImpl#doinitialize()

       if (plugin instanceof AbstractResolverPlugin<?>) {
           ((AbstractResolverPlugin<?>) plugin).setSuppressDisplayInformation(isSuppressDisplayInformation());
       }

This requires that the plugin hasn't been initialized. to work But often it is.
I spent a bunch of time fixing this but on reflection it will be easier to wait until https://shibboleth.atlassian.net/browse/IDP-1959 is done

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiZmRhZjBiYmU2ZWQ4NGY4MDhmOTFmZWYzMGIxY2QwMTkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiZmRhZjBiYmU2ZWQ4NGY4MDhmOTFmZWYzMGIxY2QwMTkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:c6c9d1f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220629/b997cb0d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f33d4926-4713-4612-9481-b85ff71f2988
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220629/b997cb0d/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a388945a-31a3-4082-b7a6-21bcb2dceaab
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220629/b997cb0d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-9a019c50-dc48-4b00-9f63-38b7351d44c7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220629/b997cb0d/attachment-0005.png>