[JIRA] (IDP-1955) Add attachClasses to the maven-war-plugin in idp-parent

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1955 ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiNmFmMzY2NWI5YzM3NDcyOWI4MjM3NTViZDA0NmZmNWIiLCJwIjoiaiJ9 )

Re: Add attachClasses to the maven-war-plugin in idp-parent ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiNmFmMzY2NWI5YzM3NDcyOWI4MjM3NTViZDA0NmZmNWIiLCJwIjoiaiJ9 )

You’re really targeting the wrong person here, I know little about Maven and I’m not the main gating factor on this. I really can’t follow any of what you’re describing, but obviously we can give this a try and attempt to understand what you mean. I definitely don’t understand this sentence:

> 
> 
> 
> All that option does is add a jar as an additional build artifact to any
> of the war modules,
> 
> 

What jar? And the documentation of this option says nothing like what you’re saying here. It says “If you would simply like to package the classes and resources as a JAR in WEB-INF/lib rather than as loose files under WEB-INF/classes”

We don’t have anything in classes. My concern is that if it does anything it’s not because it actually intentionally solves the problem (which I think I do understand) but because there’s something happening by accident that may well just change later. Maven does that kind of thing all the time.

I’ll try and run a test today with the option set and look at your sample. But with so many people out to prevent a real discussion and no patch releases imminent, it might be a pretty long while before anything happened here. Even if we did change the parent, we have no plans for any IdP patch releases that would consume it, though I imagine one will come along for some reason sooner or later.

( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiNmFmMzY2NWI5YzM3NDcyOWI4MjM3NTViZDA0NmZmNWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiNmFmMzY2NWI5YzM3NDcyOWI4MjM3NTViZDA0NmZmNWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:66eda1f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/43445ef6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-862715f3-4498-41be-9940-99ba5072f097
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/43445ef6/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8d4d2703-d66a-4382-be9b-a4de045510b9
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/43445ef6/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-096f79a3-6272-4dd4-a1b3-708cec1ae540
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/43445ef6/attachment-0005.png>