[JIRA] (JJDBC-6) Release Version 1.0.1

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JJDBC-6 ( https://shibboleth.atlassian.net/browse/JJDBC-6?atlOrigin=eyJpIjoiMDdlNGVhZGVhODAwNGMwZTkxZmIxZmVkYjljZDM0OTUiLCJwIjoiaiJ9 )

Re: Release Version 1.0.1 ( https://shibboleth.atlassian.net/browse/JJDBC-6?atlOrigin=eyJpIjoiMDdlNGVhZGVhODAwNGMwZTkxZmIxZmVkYjljZDM0OTUiLCJwIjoiaiJ9 )

so

* We can and should get rid of the non-functional api jar
* The manifest isn’t present for the impl class (and should be)
* But even with that in place:

Manifest-Version: 1.0
Created-By: Maven JAR Plugin 3.2.2
Build-Jdk-Spec: 11
Automatic-Module-Name: net.shibboleth.plugin.storage.jdbc.impl
Sealed: true

Name: net/shibboleth/plugin/storage/jdbc/impl
Implementation-Vendor: Shibboleth
Implementation-Version: 1.0.1-SNAPSHOT
Implementation-Title: jdbc-storage-impl

the code

       String version = getClass().getPackage().getImplementationVersion();

does not return the version.

I’m currently at a bit of a loss

( https://shibboleth.atlassian.net/browse/JJDBC-6#add-comment?atlOrigin=eyJpIjoiMDdlNGVhZGVhODAwNGMwZTkxZmIxZmVkYjljZDM0OTUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JJDBC-6#add-comment?atlOrigin=eyJpIjoiMDdlNGVhZGVhODAwNGMwZTkxZmIxZmVkYjljZDM0OTUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:00501c8 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220624/c7ea7ac3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6f837f74-8cde-4eb9-900a-39d09de8782b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220624/c7ea7ac3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a3ba4595-00e9-44c7-993f-f0ecb0f0d8a5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220624/c7ea7ac3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5877a696-b8e9-4c1f-805b-bada214eeb58
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220624/c7ea7ac3/attachment-0005.png>