[java-shib-attribute] branch main updated: Fix test.

Scott Cantor cantor.2 at osu.edu
Wed Jun 22 16:32:00 UTC 2022


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=4ee71dd5898bd4c86fa2f280c02fa623dd4fa932

The following commit(s) were added to refs/heads/main by this push:
     new 4ee71dd58 Fix test.
4ee71dd58 is described below

commit 4ee71dd5898bd4c86fa2f280c02fa623dd4fa932
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Jun 22 12:31:56 2022 -0400

    Fix test.
---
 .../attribute/resolver/AbstractResolverPluginTest.java   | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/shib-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPluginTest.java b/shib-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPluginTest.java
index 4a7b806d3..be9e2744e 100644
--- a/shib-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPluginTest.java
+++ b/shib-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPluginTest.java
@@ -30,7 +30,6 @@ import net.shibboleth.idp.attribute.resolver.context.AttributeResolutionContext;
 import net.shibboleth.idp.attribute.resolver.context.AttributeResolverWorkContext;
 import net.shibboleth.utilities.java.support.logic.ConstraintViolationException;
 
-import org.opensaml.messaging.context.navigate.ParentContextLookup;
 import org.opensaml.profile.context.ProfileRequestContext;
 import org.testng.Assert;
 import org.testng.annotations.Test;
@@ -43,7 +42,7 @@ public class AbstractResolverPluginTest {
 
     /** Test an instantiated object has the proper state. */
     @Test public void instantiation() {
-        MockBaseAttributeResolver plugin = new MockBaseAttributeResolver(" foo ", "bar");
+        final MockBaseAttributeResolver plugin = new MockBaseAttributeResolver(" foo ", "bar");
 
         Assert.assertEquals(plugin.getId(), "foo");
         Assert.assertTrue(plugin.isPropagateResolutionExceptions());
@@ -56,7 +55,7 @@ public class AbstractResolverPluginTest {
 
     /** Test get/set activation criteria. */
     @Test public void activationCriteria() {
-        MockBaseAttributeResolver plugin = new MockBaseAttributeResolver(" foo ", "bar");
+        final MockBaseAttributeResolver plugin = new MockBaseAttributeResolver(" foo ", "bar");
 
         plugin.setActivationCondition(Predicates.<ProfileRequestContext> alwaysFalse());
         Assert.assertEquals(plugin.getActivationCondition(), Predicates.alwaysFalse());
@@ -67,17 +66,10 @@ public class AbstractResolverPluginTest {
             // expected this
         }
     }
-    
-    @Test public void nativation() {
-        MockBaseAttributeResolver plugin = new MockBaseAttributeResolver(" foo ", "bar");
-        Assert.assertEquals(plugin.getProfileContextStrategy().getClass(), ParentContextLookup.class);
-        plugin.setProfileContextStrategy(new TestFunc());
-        Assert.assertEquals(plugin.getProfileContextStrategy().getClass(), TestFunc.class);
-    }
 
     /** Test setters to {@link AbstractResolverPlugin#setPropagateResolutionExceptions(boolean)}. */
     @Test public void propogateSetters() {
-        MockBaseAttributeResolver plugin = new MockBaseAttributeResolver("foo", "bar");
+        final MockBaseAttributeResolver plugin = new MockBaseAttributeResolver("foo", "bar");
 
         plugin.setPropagateResolutionExceptions(true);
         Assert.assertTrue(plugin.isPropagateResolutionExceptions());
@@ -91,7 +83,7 @@ public class AbstractResolverPluginTest {
 
     /** Test add, removing, setting dependencies. */
     @Test public void dependencies() {
-        MockBaseAttributeResolver plugin = new MockBaseAttributeResolver("foo", "bar");
+        final MockBaseAttributeResolver plugin = new MockBaseAttributeResolver("foo", "bar");
 
         Assert.assertNotNull(plugin.getAttributeDependencies());
         Assert.assertTrue(plugin.getAttributeDependencies().isEmpty());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list