[JIRA] (IDP-1966) Migrate PRC lookup out of plugins and into AttributeResolutionContext
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Wed Jun 22 13:35:19 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue
Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-1966?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 ) IDP-1966 ( https://shibboleth.atlassian.net/browse/IDP-1966?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 ) Migrate PRC lookup out of plugins and into AttributeResolutionContext ( https://shibboleth.atlassian.net/browse/IDP-1966?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 )
Issue Type: Improvement Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Attribute Resolver Created: 22/Jun/22 9:35 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )
There’s a PRC lookup strategy baked into the top of the resolver plugin class tree (and an accidental duplication of this in the ScriptedAttributeDefinition. The schema also allows this to be overridden.
This really isn’t the way to do things, we should have put the strategy into the AttributeResolutionContext itself to represent a given transaction’s approach to this. So it doesn’t really even work properly to bake it into the plugins since that would only work for a given placement.
We should deprecate the schema attribute and then move the setting out.
( https://shibboleth.atlassian.net/browse/IDP-1966#add-comment?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1966#add-comment?atlOrigin=eyJpIjoiMWQ5MjA1NTFmOWUyNDcwMjk2YmIyMDBmMmE4NTQwYmUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:5c1db44 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220622/f8a174c7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-8fe192fe-e837-4a84-9a98-be9531712180
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220622/f8a174c7/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5508aba6-6bbe-4811-9d81-259e8f488a01
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220622/f8a174c7/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-5a578b75-6f71-4398-8e4c-95f4091da461
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220622/f8a174c7/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-39ec9aea-76c5-4397-8061-b953c7fc5829
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220622/f8a174c7/attachment-0007.png>
More information about the commits
mailing list