[JIRA] (JSE-49) Allow NamespaceHandler base class to sub-delegate to additional handlers
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Fri Jun 17 18:12:22 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue
Spring Extensions ( https://shibboleth.atlassian.net/browse/JSE?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 ) / New Feature ( https://shibboleth.atlassian.net/browse/JSE-49?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 ) JSE-49 ( https://shibboleth.atlassian.net/browse/JSE-49?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 ) Allow NamespaceHandler base class to sub-delegate to additional handlers ( https://shibboleth.atlassian.net/browse/JSE-49?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 )
Issue Type: New Feature Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Created: 17/Jun/22 2:12 PM Fix Versions: 7.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )
We have cases where a single schema includes plugins that are definitely not IdP-specific but others that probably are and depend on classes that aren’t likely to move out of the IdP. Unless we go back to multiple namespaces (and break the existing xsi:types people are using, again), we would have to define the schema at the lower level but allow some of the types to be handled by a higher layer.
The DefaultNamespaceHandlerResolver in Spring’s bean definition reader is limited to one handler per namespace. We could override this by plugging our own in and using our custom reader class to install it, but that’s probably more invasive to keep working than just implementing our own extension in our NamespaceHandler base class that allows it to delegate registrations to another class. That would let the parsers live at either layer for the same schema namespace.
We probably just do this with META-INF/somethingnew and instantiating the classes with reflection, same way Spring does it.
( https://shibboleth.atlassian.net/browse/JSE-49#add-comment?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSE-49#add-comment?atlOrigin=eyJpIjoiMzllMTM5YjRlZGUxNGUyNTgwYmJiZDQwMzA1Zjg5ZmUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:07cea57 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220617/504b846c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e753ee42-384d-43a4-bb1d-b28026fcc07b
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220617/504b846c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2c100417-6b6f-40a9-ac32-30771e881043
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220617/504b846c/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b9d8a5db-910d-4856-9e03-0af9bcb67146
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220617/504b846c/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-efe0128a-40bf-4478-ab57-8767ac0e2e71
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220617/504b846c/attachment-0007.png>
More information about the commits
mailing list